Skip to content

Conversation

@Mini256
Copy link
Member

@Mini256 Mini256 commented Aug 28, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2023
@Mini256 Mini256 requested review from Icemap, Oreoxmt and wd0517 August 28, 2023 06:34
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 28, 2023

@Mini256 Mini256#1 PTAL

@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs This PR is translated from a PR in pingcap/docs. area/develop This PR relates to the area of TiDB App development. labels Aug 28, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Aug 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2023

@wd0517: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2023
@Oreoxmt Oreoxmt self-requested a review August 28, 2023 08:25
github-actions bot pushed a commit to Oreoxmt/pingcap-docs-website-scaffold that referenced this pull request Aug 28, 2023
Mini256 and others added 2 commits August 28, 2023 17:25
Co-authored-by: Aolin <aolinz@outlook.com>
@Mini256 Mini256 requested a review from sykp241095 August 29, 2023 02:52
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@Mini256 Mini256 requested a review from Oreoxmt August 31, 2023 07:30
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-29 07:40:54.196809276 +0000 UTC m=+1826418.745825262: ☑️ agreed by ran-huang.
  • 2023-08-31 07:42:44.268999176 +0000 UTC m=+1999328.818015162: ☑️ agreed by Oreoxmt.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 31, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit 198f109 into pingcap:master Aug 31, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14941.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14942.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14943.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #14944.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/develop This PR relates to the area of TiDB App development. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants