Skip to content

Conversation

@yibin87
Copy link
Contributor

@yibin87 yibin87 commented Nov 24, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2023
Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

@xzhangxian1008: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai self-assigned this Nov 24, 2023
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Nov 24, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 24, 2023
Co-authored-by: Grace Cai <qqzczy@126.com>
@yibin87 yibin87 requested a review from qiancai November 24, 2023 07:00
@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. v7.5 This PR/issue applies to TiDB v7.5. labels Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 08:05:47.492696563 +0000 UTC m=+564376.157922758: ☑️ agreed by qiancai.

@qiancai qiancai added lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed v7.5 This PR/issue applies to TiDB v7.5. labels Nov 24, 2023
@qiancai
Copy link
Collaborator

qiancai commented Nov 24, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 24, 2023
@qiancai qiancai added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Nov 24, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1887002 into pingcap:master Nov 24, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15498.

@qiancai qiancai added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Nov 24, 2023
@qiancai qiancai removed their assignment Nov 24, 2023
@CrystalAnalyst
Copy link

/assign

@qiancai
Copy link
Collaborator

qiancai commented Jan 4, 2024

/assign @CrystalAnalyst

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. type/enhancement The issue or PR belongs to an enhancement.

Development

Successfully merging this pull request may close these issues.

6 participants