Skip to content

Conversation

@CrystalAnalyst
Copy link
Contributor

@CrystalAnalyst CrystalAnalyst commented Jan 9, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add some explanation for tiflash tuning performance doc

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Jan 9, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 9, 2024

Welcome @CrystalAnalyst!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2024
@dveeden
Copy link
Contributor

dveeden commented Jan 9, 2024

From the linter:

tiflash/tune-tiflash-performance.md: 310: MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

@qiancai qiancai added 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jan 9, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 9, 2024
@qiancai qiancai requested a review from Oreoxmt January 9, 2024 09:15
@Oreoxmt Oreoxmt changed the title Translate Add some explanation for tiflash tuning performance doc Jan 9, 2024
@Oreoxmt Oreoxmt requested a review from qiancai January 9, 2024 09:28
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 9, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 9, 2024
@rpaik
Copy link
Member

rpaik commented Jan 9, 2024

Thanks for your contribution to TiDB Docs Dash @CrystalAnalyst 🎊

@CrystalAnalyst
Copy link
Contributor Author

@Oreoxmt @qiancai Hi ~ would you take some time review my changes ? I'd appreciated that, thanks!

@CrystalAnalyst
Copy link
Contributor Author

@Oreoxmt Sorry to bother, but the DDL is approaching, can you review and approve the change ? If there's still room for improvement, I'm glad to change.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 12, 2024

@CrystalAnalyst

Thank you for reaching out, and no worries at all. Just to clarify, the deadline for this TiDB Docs Dash event is to merge this PR before January 26th (see https://www.pingcap.com/event/tidb-docs-dash/). Currently, we're handling a significant backlog of PRs waiting for review. I'll prioritize reviewing and merging your PR, but it might take a bit of time due to the high volume of pending requests.

@CrystalAnalyst
Copy link
Contributor Author

@CrystalAnalyst

Thank you for reaching out, and no worries at all. Just to clarify, the deadline for this TiDB Docs Dash event is to merge this PR before January 26th (see https://www.pingcap.com/event/tidb-docs-dash/). Currently, we're handling a significant backlog of PRs waiting for review. I'll prioritize reviewing and merging your PR, but it might take a bit of time due to the high volume of pending requests.

Oh! I see. Wish you good luck!

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-09 10:59:59.011472959 +0000 UTC m=+354588.595726637: ☑️ agreed by dveeden.
  • 2024-01-24 02:21:09.751562531 +0000 UTC m=+927311.315860220: ☑️ agreed by Oreoxmt.

Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@Oreoxmt Oreoxmt removed the request for review from qiancai January 24, 2024 05:02
Co-authored-by: Ran <huangran.alex@gmail.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 24, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3edf2d3 into pingcap:master Jan 24, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16251.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Development

Successfully merging this pull request may close these issues.

8 participants