update doc for max_user_connections. by joccau · Pull Request #19898 · pingcap/docs-cn

joccau · 2025-02-24T14:00:09Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): update doc for max-user-connections docs#20488

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Signed-off-by: joccau <zak.zhao@pingcap.cn>

system-variables.md

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau · 2025-02-26T06:15:40Z

/test pull-verify

system-variables.md

ti-chi-bot · 2025-02-26T06:34:32Z

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joccau · 2025-02-27T03:01:25Z

/cc @dveeden This PR is the Chinese doc, and I will make PR for English doc later.

dveeden · 2025-02-27T07:22:33Z

sql-statements/sql-statement-alter-user.md

+
+```sql
+ALTER USER 'newuser' WITH MAX_USER_CONNECTIONS 3;
+SELECT USER, HOST, MAX_USER_CONNECTIONS FROM MYSQL.USER WHERE USER='newuser';


Suggested change

SELECT USER, HOST, MAX_USER_CONNECTIONS FROM MYSQL.USER WHERE USER='newuser';

SELECT User, Host, max_user_connections FROM mysql.user WHERE User='newuser';

The column names are stored with a specific case. While they should work when compared with any other case it is best to keep these identical.

Using system tables directly should be avoided.

So insert of this GRANT, CREATE USER, etc should be used.

In this case could SHOW CREATE USER... or SHOW GRANTS FOR... be used?

I guess this is following the same format as other examples.

I'm ok if this is changed for all examples in a separate PR some time later.

I guess this is following the same format as other examples.

I'm ok if this is changed for all examples in a separate PR some time later.

Yes, It is used for showing the field max_user_connections when creating user WITH MAX_CONNECTIONS N.

I think this might be a better way than SELECT ... mysql.user...:

mysql-8.0.11-TiDB-v9.0.0-alpha-340-gd392685> CREATE USER 'u1'@'%' IDENTIFIED BY 'really_really_secret' WITH MAX_USER_CONNECTIONS 123; Query OK, 0 rows affected (0.03 sec) mysql-8.0.11-TiDB-v9.0.0-alpha-340-gd392685> SHOW CREATE USER 'u1'@'%'\G *************************** 1. row *************************** CREATE USER for u1@%: CREATE USER 'u1'@'%' IDENTIFIED WITH 'mysql_native_password' AS '*D4EF4C5A994EF8283FB666D79DCADE5B6A764D4E' REQUIRE NONE WITH MAX_USER_CONNECTIONS 123 PASSWORD EXPIRE DEFAULT ACCOUNT UNLOCK PASSWORD HISTORY DEFAULT PASSWORD REUSE INTERVAL DEFAULT 1 row in set (0.01 sec)

mysql-schema/mysql-schema-user.md

Signed-off-by: joccau <zak.zhao@pingcap.cn>

Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>

sql-statements/sql-statement-create-user.md

ti-chi-bot · 2025-02-28T06:44:56Z

[LGTM Timeline notifier]

Timeline:

2025-02-26 03:17:22.701871365 +0000 UTC m=+412190.655029630: ☑️ agreed by hfxsd.
2025-02-28 06:44:55.458155171 +0000 UTC m=+597443.411313421: ☑️ agreed by dveeden.

Co-authored-by: Daniël van Eeden <github@myname.nl>

sql-statements/sql-statement-alter-user.md

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

system-variables.md

qiancai

Rest LGTM

security-compatibility-with-mysql.md

system-variables.md

Co-authored-by: Grace Cai <qqzczy@126.com>

system-variables.md

Co-authored-by: Daniël van Eeden <github@myname.nl>

system-variables.md

into pr/19898

Co-authored-by: Grace Cai <qqzczy@126.com>

system-variables.md

Co-authored-by: Grace Cai <qqzczy@126.com>

hfxsd · 2025-03-17T06:32:16Z

/approve

ti-chi-bot · 2025-03-17T06:32:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [hfxsd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2025

joccau force-pushed the max-user-connections branch from f91427c to a49b734 Compare February 24, 2025 14:58

update doc for max_user_connections.

b08ca9f

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau force-pushed the max-user-connections branch from a49b734 to b08ca9f Compare February 25, 2025 04:32

hfxsd reviewed Feb 26, 2025

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

Update system-variables.md

61e2041

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

hfxsd approved these changes Feb 26, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 26, 2025

hfxsd requested a review from Frank945946 February 26, 2025 03:18

update doc

4d52737

Signed-off-by: joccau <zak.zhao@pingcap.cn>

Frank945946 approved these changes Feb 26, 2025

View reviewed changes

system-variables.md Show resolved Hide resolved

lilin90 assigned hfxsd Feb 27, 2025

dveeden reviewed Feb 27, 2025

View reviewed changes

mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved

update doc about max_user_connections

d1896c1

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau requested a review from dveeden February 28, 2025 03:20

Update system-variables.md

cde3be2

Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>

dveeden reviewed Feb 28, 2025

View reviewed changes

sql-statements/sql-statement-create-user.md Outdated Show resolved Hide resolved

dveeden reviewed Feb 28, 2025

View reviewed changes

sql-statements/sql-statement-create-user.md Outdated Show resolved Hide resolved

dveeden approved these changes Feb 28, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 28, 2025

joccau and others added 3 commits March 3, 2025 10:11

Update sql-statements/sql-statement-create-user.md

c05e962

Co-authored-by: Daniël van Eeden <github@myname.nl>

Update sql-statement-create-user.md

2873a10

Update sql-statement-create-user.md

b9cdd1b

hfxsd reviewed Mar 3, 2025

View reviewed changes

sql-statements/sql-statement-alter-user.md Outdated Show resolved Hide resolved

Update sql-statements/sql-statement-alter-user.md

ab9a79a

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

hfxsd reviewed Mar 7, 2025

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

hfxsd added 3 commits March 7, 2025 09:08

Update system-variables.md

0b26ab1

Merge remote-tracking branch 'upstream/master' into pr/19898

850176f

fix links

226acf6

hfxsd requested a review from qiancai March 7, 2025 02:47

joccau mentioned this pull request Mar 7, 2025

update doc for max-user-connections pingcap/docs#20488

Merged

16 tasks

hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 7, 2025

qiancai approved these changes Mar 14, 2025

View reviewed changes

security-compatibility-with-mysql.md Outdated Show resolved Hide resolved

system-variables.md Outdated Show resolved Hide resolved

system-variables.md Outdated Show resolved Hide resolved

joccau and others added 3 commits March 14, 2025 12:59

Update security-compatibility-with-mysql.md

576a189

Co-authored-by: Grace Cai <qqzczy@126.com>

Update system-variables.md

be0ffcd

Co-authored-by: Grace Cai <qqzczy@126.com>

Update system-variables.md

73623f3

Co-authored-by: Grace Cai <qqzczy@126.com>

dveeden reviewed Mar 14, 2025

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

Update system-variables.md

35619dd

Co-authored-by: Daniël van Eeden <github@myname.nl>

qiancai reviewed Mar 17, 2025

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

hfxsd and others added 3 commits March 17, 2025 11:39

Merge remote-tracking branch 'upstream/master' into pr/19898

3de779e

Merge branch 'max-user-connections' of https://github.com/joccau/docs-cn

2b1e178

into pr/19898

Update system-variables.md

31e22f6

Co-authored-by: Grace Cai <qqzczy@126.com>

qiancai reviewed Mar 17, 2025

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

Update system-variables.md

ceba8c2

Co-authored-by: Grace Cai <qqzczy@126.com>

ti-chi-bot bot added the approved label Mar 17, 2025

ti-chi-bot bot merged commit 4f77c01 into pingcap:master Mar 17, 2025
7 checks passed

	SELECT USER, HOST, MAX_USER_CONNECTIONS FROM MYSQL.USER WHERE USER='newuser';
	SELECT User, Host, max_user_connections FROM mysql.user WHERE User='newuser';

Conversation

joccau commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

Uh oh!

joccau commented Feb 26, 2025

Uh oh!

Uh oh!

ti-chi-bot bot commented Feb 26, 2025

Uh oh!

joccau commented Feb 27, 2025

Uh oh!

dveeden Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

dveeden Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

dveeden Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

joccau Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

dveeden Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot bot commented Feb 28, 2025

[LGTM Timeline notifier]

Uh oh!

Uh oh!

Uh oh!

qiancai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hfxsd commented Mar 17, 2025

Uh oh!

ti-chi-bot bot commented Mar 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joccau commented Feb 24, 2025 •

edited

Loading