Skip to content

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Sep 10, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Sep 10, 2025
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 10, 2025
@hfxsd hfxsd added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 10, 2025
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 11, 2025
@hfxsd hfxsd removed the contribution This PR is from a community contributor. label Sep 11, 2025
@hfxsd hfxsd requested a review from songrijie September 11, 2025 06:56
@hfxsd hfxsd added the area/best-practices Adds or updates TiDB best practices. label Sep 11, 2025
Comment on lines 132 to 136
与在单节点提供洞察的 `TIDB_INDEX_USAGE` 不同,提供集群级视图的 `CLUSTER_TIDB_INDEX_USAGE` 支持下列功能:

- 检测索引使用不一致。例如,某索引在部分节点常用,其他节点未用。
- 分析分布式查询的全局索引模式,确保索引决策反映实际负载分布。
- 优化全节点索引策略,提升多节点部署下的查询效率。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section looks obscure to me. Shall we remove it?

Co-authored-by: Roger Song <roger.song@pingcap.com>
@hfxsd hfxsd requested a review from lilin90 September 18, 2025 09:11
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 23, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-23 03:13:54.972938174 +0000 UTC m=+326445.043431856: ☑️ agreed by lilin90.

@hfxsd hfxsd added the lgtm label Sep 23, 2025
@hfxsd
Copy link
Collaborator Author

hfxsd commented Sep 23, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit 75a8861 into pingcap:master Sep 23, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20945.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/best-practices Adds or updates TiDB best practices. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants