Skip to content

*: enrich best practices index and move one doc#21309

Merged
lilin90 merged 3 commits intopingcap:feature/preview-top-navigationfrom
lilin90:enrich-best-practices-index
Feb 2, 2026
Merged

*: enrich best practices index and move one doc#21309
lilin90 merged 3 commits intopingcap:feature/preview-top-navigationfrom
lilin90:enrich-best-practices-index

Conversation

@lilin90
Copy link
Member

@lilin90 lilin90 commented Feb 2, 2026

What is changed, added or deleted? (Required)

  • Moved best-practices-on-public-cloud.md to best-practices/best-practices-on-public-cloud.md
  • Enriched the content for best-practices/_index.md

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 requested a review from qiancai February 2, 2026 06:36
@lilin90 lilin90 self-assigned this Feb 2, 2026
@lilin90 lilin90 added the type/refactor The issue belongs to a refactor work. label Feb 2, 2026
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2026
@lilin90 lilin90 added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Feb 2, 2026
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Feb 2, 2026
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 2, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 2, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-02 07:21:56.608300045 +0000 UTC m=+78787.709698768: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 2, 2026

@lilin90: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 8550c10 link true /test pull-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member Author

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 2, 2026
@lilin90 lilin90 added the lgtm label Feb 2, 2026
@lilin90 lilin90 merged commit 2decde2 into pingcap:feature/preview-top-navigation Feb 2, 2026
4 of 7 checks passed
@lilin90 lilin90 deleted the enrich-best-practices-index branch February 2, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/refactor The issue belongs to a refactor work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants