Skip to content

Conversation

@jackysp
Copy link
Member

@jackysp jackysp commented Apr 15, 2020

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What is changed, added or deleted? (Required)

Change error code format. Nearly no content changes.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp added status/WIP This PR is still working in progress. needs-cherry-pick-4.0 labels Apr 15, 2020
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp requested a review from lilin90 April 15, 2020 07:53
@jackysp jackysp changed the title reference: polish error code reference: change error code format to list Apr 15, 2020
@jackysp jackysp added needs-cherry-pick-4.0 and removed needs-cherry-pick-4.0 status/WIP This PR is still working in progress. labels Apr 15, 2020
jackysp and others added 2 commits April 15, 2020 15:56
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Apr 15, 2020
@lilin90 lilin90 assigned toutdesuite and jackysp and unassigned toutdesuite Apr 15, 2020
@jackysp jackysp merged commit c90f84d into master Apr 15, 2020
@lilin90 lilin90 deleted the polish_error_code branch April 15, 2020 08:37
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

cherry pick to release-4.0 in PR #2760

lilin90 pushed a commit that referenced this pull request Apr 15, 2020
Co-authored-by: Jack Yu <yusp@pingcap.com>
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 15, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants