Skip to content

Conversation

@superlzs0476
Copy link
Contributor

@superlzs0476 superlzs0476 commented Apr 15, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@superlzs0476
Copy link
Contributor Author

@yikeke @kissmydb PTAL

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 15, 2020

还有其他的文档也应该顺便改下,等我commit再合

@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Apr 15, 2020
@yikeke yikeke requested a review from kissmydb April 15, 2020 10:55
@yikeke yikeke changed the title how-to/deploy:fix-deploy-link *: update recommended deployment method in multiple docs to TiUP method Apr 15, 2020
@yikeke yikeke assigned ran-huang and unassigned toutdesuite Apr 15, 2020
@superlzs0476
Copy link
Contributor Author

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 15, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

/run-all-tests

@yikeke yikeke merged commit a5a8899 into master Apr 15, 2020
@yikeke yikeke deleted the fix-deploy-link branch April 15, 2020 14:14
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 15, 2020
…od (pingcap#2768)

* how-to/deploy:fix-deploy-link

* Modify other docs

* fix format in tiup deploy doc

Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

cherry pick to release-4.0 in PR #2773

@yikeke yikeke added priority/P1 The issue has P1 priority. size/small Changes of a small size. labels Apr 15, 2020
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 16, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
…od (pingcap#2768)

* how-to/deploy:fix-deploy-link

* Modify other docs

* fix format in tiup deploy doc

Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/P1 The issue has P1 priority. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants