Skip to content

Conversation

@marsishandsome
Copy link
Contributor

@marsishandsome marsishandsome commented Apr 15, 2020

What is changed, added or deleted? (Required)

tiflash currently does not support tiup cluster upgrade

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to.confirm that tiflash is down before we run update?

Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke changed the title update tiflash upgrade document tiflash: update tiflash upgrade document Apr 15, 2020
@marsishandsome marsishandsome merged commit 67a2e07 into pingcap:master Apr 15, 2020
@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Apr 15, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

cherry pick to release-4.0 in PR #2772

yikeke pushed a commit that referenced this pull request Apr 15, 2020
Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
@yikeke yikeke added priority/P1 The issue has P1 priority. size/small Changes of a small size. labels Apr 16, 2020
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 16, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/P1 The issue has P1 priority. size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants