-
Notifications
You must be signed in to change notification settings - Fork 1.2k
reference: add more descriptions to readpool.unified #2776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
5 tasks
TomShawn
approved these changes
Apr 16, 2020
Contributor
TomShawn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
| ## readpool.unified | ||
|
|
||
| 统一处理读请求的线程池相关的配置项。 | ||
| 统一处理读请求的线程池相关的配置项。该线程池在 4.0 版本中取代原有的 storage 和 coprocessor 线程池。 |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| 统一处理读请求的线程池相关的配置项。该线程池在 4.0 版本中取代原有的 storage 和 coprocessor 线程池。 | |
| 统一处理读请求的线程池相关的配置项。该线程池自 4.0 版本起取代原有的 storage 和 coprocessor 线程池。 |
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
youjiali1995
approved these changes
Apr 16, 2020
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-4.0 in PR #2790 |
5 tasks
sre-bot
added a commit
that referenced
this pull request
Apr 16, 2020
rleungx
pushed a commit
to rleungx/docs-cn
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
size/small
Changes of a small size.
status/can-merge
Indicates a PR has been approved by a committer.
translation/done
This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yilin Chen sticnarf@gmail.com
What is changed, added or deleted? (Required)
Add more descriptions to the unified read pool. It would help users understand better.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?