Skip to content

Conversation

@sticnarf
Copy link
Contributor

@sticnarf sticnarf commented Apr 16, 2020

Signed-off-by: Yilin Chen sticnarf@gmail.com

What is changed, added or deleted? (Required)

Add more descriptions to the unified read pool. It would help users understand better.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

## readpool.unified

统一处理读请求的线程池相关的配置项。
统一处理读请求的线程池相关的配置项。该线程池在 4.0 版本中取代原有的 storage 和 coprocessor 线程池。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
统一处理读请求的线程池相关的配置项。该线程池在 4.0 版本中取代原有的 storage 和 coprocessor 线程池。
统一处理读请求的线程池相关的配置项。该线程池自 4.0 版本起取代原有的 storage 和 coprocessor 线程池。

@TomShawn TomShawn added size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Apr 16, 2020
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf requested a review from youjiali1995 April 16, 2020 07:56
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot sre-bot merged commit cc99606 into pingcap:master Apr 16, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-4.0 in PR #2790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants