Skip to content

Conversation

@marsishandsome
Copy link
Contributor

@marsishandsome marsishandsome commented Apr 16, 2020

What is changed, added or deleted? (Required)

add warning to upgrade pre-rc version of tiflash

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@marsishandsome marsishandsome force-pushed the feature/add-warning-to-upgrade-tiflash branch from 74d37a9 to 4c36227 Compare April 16, 2020 04:37
@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Apr 16, 2020
@yikeke yikeke self-assigned this Apr 16, 2020
@yikeke yikeke changed the title add warning to upgrade pre-rc version of tiflash tiflash: add warning to upgrade pre-rc version of tiflash Apr 16, 2020
@yikeke yikeke changed the title tiflash: add warning to upgrade pre-rc version of tiflash tiflash: add warning to upgrade from pre-rc version Apr 16, 2020
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome requested review from ilovesoup and removed request for ilovesoup April 16, 2020 06:46
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 16, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot sre-bot merged commit cb0e766 into pingcap:master Apr 16, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 16, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-3.1 in PR #2786

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-4.0 in PR #2787

yikeke pushed a commit that referenced this pull request Apr 16, 2020
Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
@yikeke yikeke added the size/small Changes of a small size. label Apr 17, 2020
@yikeke yikeke assigned TomShawn and unassigned yikeke Apr 17, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 20, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants