-
Notifications
You must be signed in to change notification settings - Fork 1.2k
tiflash: add warning to upgrade from pre-rc version #2778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sre-bot
merged 4 commits into
pingcap:master
from
marsishandsome:feature/add-warning-to-upgrade-tiflash
Apr 16, 2020
Merged
tiflash: add warning to upgrade from pre-rc version #2778
sre-bot
merged 4 commits into
pingcap:master
from
marsishandsome:feature/add-warning-to-upgrade-tiflash
Apr 16, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74d37a9 to
4c36227
Compare
yikeke
reviewed
Apr 16, 2020
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke
reviewed
Apr 16, 2020
Contributor
yikeke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ilovesoup
approved these changes
Apr 16, 2020
Contributor
ilovesoup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
/merge |
Contributor
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Apr 16, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-3.1 in PR #2786 |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Apr 16, 2020
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #2787 |
yikeke
pushed a commit
that referenced
this pull request
Apr 16, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 16, 2020
5 tasks
This was referenced Apr 17, 2020
rleungx
pushed a commit
to rleungx/docs-cn
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
size/small
Changes of a small size.
status/can-merge
Indicates a PR has been approved by a committer.
translation/done
This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
add warning to upgrade pre-rc version of tiflash
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?