Skip to content

tools: update ticdc common maintenance #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 29, 2020
Merged

tools: update ticdc common maintenance #2909

merged 9 commits into from
Apr 29, 2020

Conversation

@amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Apr 28, 2020

What is changed, added or deleted? (Required)

Add maintenance document in TiCDC

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn added size/large Changes of a large size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Apr 28, 2020
@TomShawn TomShawn self-assigned this Apr 28, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Apr 28, 2020 •
edited
Loading

@amyangfei Please fix the CI failure and involve a technical review.

@amyangfei
Copy link
Contributor Author

amyangfei commented Apr 28, 2020 •
edited
Loading

fixed, PTAL, thanks @TomShawn

@amyangfei
Copy link
Contributor Author

amyangfei commented Apr 28, 2020

PTAL @leoppro

@TomShawn TomShawn requested a review from zier-one April 28, 2020 13:57
zier-one
zier-one approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei
Copy link
Contributor Author

amyangfei commented Apr 29, 2020

PTAL @TomShawn thanks!

overvenus
overvenus reviewed Apr 29, 2020
View reviewed changes
overvenus
overvenus reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

TomShawn
TomShawn approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei merged commit 57e4ab0 into pingcap:master Apr 29, 2020
@amyangfei amyangfei deleted the update-cdc-docs branch April 29, 2020 11:36
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 29, 2020
@amyangfei @TomShawn @sre-bot
tools: update ticdc common maintenance (pingcap#2909)
bfefc82 
Co-authored-by: TomShawn <1135243111@qq.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request Apr 29, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2020

cherry pick to release-4.0 in PR #2927

TomShawn added a commit that referenced this pull request Apr 29, 2020
@sre-bot @amyangfei @TomShawn
tools: update ticdc common maintenance (#2909) (#2927)
3bd02d8 
Co-authored-by: TomShawn <1135243111@qq.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: amyangfei <amyangfei@gmail.com>
Co-authored-by: TomShawn <1135243111@qq.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@amyangfei amyangfei mentioned this pull request Apr 30, 2020
Closed
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
@amyangfei @TomShawn @rleungx
tools: update ticdc common maintenance (pingcap#2909)
12d1692 
Co-authored-by: TomShawn <1135243111@qq.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@toutdesuite toutdesuite mentioned this pull request Jun 5, 2020
Merged
5 tasks
@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
5 tasks
@toutdesuite toutdesuite mentioned this pull request Jun 8, 2020
Merged
5 tasks
@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
5 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 9, 2020
@TomShawn TomShawn mentioned this pull request Jun 9, 2020
Merged
5 tasks
@sre-bot sre-bot mentioned this pull request Jun 12, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus left review comments

+2 more reviewers

@zier-one zier-one zier-one approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

size/large Changes of a large size. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amyangfei @TomShawn @sre-bot @overvenus @zier-one