Skip to content

Conversation

@lysu
Copy link
Contributor

@lysu lysu commented Apr 29, 2020

What is changed, added or deleted? (Required)

fix typo

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?


This change is Reviewable

@TomShawn TomShawn added needs-cherry-pick-3.1 translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. status/PTAL This PR is ready for reviewing. labels May 1, 2020
@TomShawn
Copy link
Contributor

TomShawn commented May 1, 2020

LGTM

@lysu lysu requested a review from jackysp May 8, 2020 02:56
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor Author

lysu commented May 8, 2020

LGTM for @toutdesuite 's last comments~

Copy link
Contributor

@toutdesuite toutdesuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label May 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

/run-all-tests

@toutdesuite toutdesuite added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 8, 2020
@toutdesuite toutdesuite changed the title how-to/secure: fix typo for reload tls *: fix typo for reload tls May 8, 2020
@sre-bot sre-bot merged commit a5f6eec into master May 8, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
@sre-bot sre-bot mentioned this pull request May 8, 2020
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

cherry pick to release-3.1 in PR #3006

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
@sre-bot sre-bot mentioned this pull request May 8, 2020
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

cherry pick to release-4.0 in PR #3007

TomShawn pushed a commit that referenced this pull request May 8, 2020
Co-authored-by: lysu <sulifx@gmail.com>
TomShawn pushed a commit that referenced this pull request May 8, 2020
Co-authored-by: lysu <sulifx@gmail.com>
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
@yikeke yikeke deleted the lysu-patch-1 branch May 28, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants