Skip to content

reference: enlarge txn-total-size-limit when binlog enabled #2980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2020
Merged

reference: enlarge txn-total-size-limit when binlog enabled #2980

merged 2 commits into from
May 8, 2020

Conversation

@jackysp
Copy link
Member

@jackysp jackysp commented May 7, 2020 •
edited
Loading

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@jackysp
reference: enlarge txn-total-size-limit when binlog enabled
22eeb94 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp requested review from lysu and tiancaiamao May 7, 2020 13:27
@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels May 7, 2020
@TomShawn TomShawn self-assigned this May 7, 2020
lysu
lysu reviewed May 8, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label May 8, 2020
@jackysp
Copy link
Member Author

jackysp commented May 8, 2020

PTAL @TomShawn

TomShawn
TomShawn approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit dd455d3 into pingcap:master May 8, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
@jackysp @sre-bot
reference: enlarge txn-total-size-limit when binlog enabled (pingcap#…
dbdd1da 
…2980)
@sre-bot sre-bot mentioned this pull request May 8, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

cherry pick to release-4.0 in PR #2987

TomShawn pushed a commit that referenced this pull request May 8, 2020
@sre-bot @jackysp
reference: enlarge txn-total-size-limit when binlog enabled (#2980) (#…
97449b8 
…2987)

Co-authored-by: Jack Yu <yusp@pingcap.com>
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
@jackysp @rleungx
reference: enlarge txn-total-size-limit when binlog enabled (pingcap#…
5b9d730 
…2980)
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@TomShawn TomShawn mentioned this pull request Jul 2, 2020
Merged
5 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

2 more reviewers

@lysu lysu lysu left review comments

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jackysp @sre-bot @lysu @TomShawn @yikeke