Skip to content

Conversation

@birdstorm
Copy link
Contributor

What is changed, added or deleted? (Required)

Add TiFlash edit-config instruction after manually scaled in TiFlash nodes

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@birdstorm birdstorm added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. needs-cherry-pick-4.0 labels Jun 1, 2020
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion, Rest LGTM

@yikeke yikeke added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 1, 2020
@yikeke yikeke self-assigned this Jun 1, 2020
birdstorm and others added 2 commits June 3, 2020 14:02
@yikeke yikeke merged commit 55e8f2c into pingcap:master Jun 3, 2020
@birdstorm birdstorm deleted the add-tiflash-edit-config branch June 3, 2020 06:05
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 3, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

cherry pick to release-4.0 in PR #3469

yikeke pushed a commit that referenced this pull request Jun 3, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: birdstorm <samuelwyf@hotmail.com>
yikeke pushed a commit to yikeke/docs that referenced this pull request Jun 5, 2020
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 5, 2020
sre-bot added a commit to pingcap/docs that referenced this pull request Jun 8, 2020
* translate pingcap/docs-cn#3208

* translate pingcap/docs-cn#3341

* translate pingcap/docs-cn#3431

* remove taking node down section in tiflash/maintain-tiflash.md

* Apply suggestions from code review

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants