Skip to content

deploy: fix issues in deployment docs #3457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 6, 2020
Merged

deploy: fix issues in deployment docs #3457

merged 12 commits into from
Jun 6, 2020
+49 −63

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 2, 2020

What is changed, added or deleted? (Required)

Fix several issues in the deployment docs.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ran-huang ran-huang added translation/no-need No need to translate this PR. status/WIP This PR is still working in progress. needs-cherry-pick-4.0 labels Jun 2, 2020
yikeke
yikeke reviewed Jun 2, 2020
View reviewed changes
This was referenced Jun 2, 2020
Merged
Merged
ran-huang and others added 2 commits June 2, 2020 18:43
@ran-huang @yikeke
Update hardware-and-software-requirements.md
76a4361 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@ran-huang
rm redundant note
b347c88
@ran-huang ran-huang mentioned this pull request Jun 3, 2020
Merged
5 tasks
@ran-huang ran-huang mentioned this pull request Jun 3, 2020
Merged
5 tasks
@yikeke
Copy link
Contributor

yikeke commented Jun 3, 2020

PTAL at this commit @superlzs0476

yikeke
yikeke approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor Author

ran-huang commented Jun 6, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2020
@ran-huang ran-huang removed the status/WIP This PR is still working in progress. label Jun 6, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 6, 2020

/run-all-tests

@sre-bot sre-bot merged commit a51e524 into pingcap:master Jun 6, 2020
@ran-huang ran-huang deleted the fix-deployment-doc branch June 6, 2020 04:43
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 6, 2020
@ran-huang @sre-bot
cherry pick pingcap#3457 to release-4.0
2775494 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 6, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 6, 2020

cherry pick to release-4.0 in PR #3539

ran-huang added a commit that referenced this pull request Jun 6, 2020
@sre-bot @ran-huang
cherry pick #3457 to release-4.0 (#3539)
57cf445 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@yikeke yikeke yikeke approved these changes

@superlzs0476 superlzs0476 superlzs0476 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ran-huang @yikeke @sre-bot @superlzs0476