Skip to content

Conversation

@lichunzhu
Copy link
Contributor

What is changed, added or deleted? (Required)

TiUP offline package doesn't support private http mirror now. This PR delete related documents.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@lichunzhu lichunzhu requested review from lucklove and yikeke June 2, 2020 15:00
@lichunzhu lichunzhu added the status/PTAL This PR is ready for reviewing. label Jun 2, 2020
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 3, 2020
@yikeke yikeke self-assigned this Jun 3, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 3, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

/run-all-tests

@yikeke yikeke merged commit ecc1894 into pingcap:master Jun 3, 2020
@lichunzhu lichunzhu deleted the removeInvalidTiUPCommand branch June 3, 2020 02:34
@yikeke yikeke changed the title remove invalid tiup cmd remove invalid tiup cmd and fix a build issue Jun 3, 2020
@yikeke
Copy link
Contributor

yikeke commented Jun 3, 2020

/run-cherry-picker

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 3, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 3, 2020
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

cherry pick to release-4.0 in PR #3466

sre-bot added a commit that referenced this pull request Jun 3, 2020
@ran-huang ran-huang assigned ran-huang and unassigned ran-huang Jun 8, 2020
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 28, 2020
yikeke pushed a commit to pingcap/docs that referenced this pull request Jun 28, 2020
yikeke added a commit to pingcap/docs that referenced this pull request Jul 1, 2020
* create and rename file; update TOC and docs guide

* align the rest of pingcap/docs-cn#3197

* Update TOC.md

* add an alias

* align https://github.com/pingcap/docs-cn/pull/3417/files

* align pingcap/docs-cn#3463 and pingcap/docs-cn#3425

* update aliases

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* add summary and update format

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update tiup/tiup-component-management.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants