Skip to content

Conversation

@superlzs0476
Copy link
Contributor

@superlzs0476 superlzs0476 commented Jun 3, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@superlzs0476
Copy link
Contributor Author

@bb7133 PTAL

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2020
@bb7133
Copy link
Member

bb7133 commented Jun 3, 2020

PTAL @yikeke

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 3, 2020
@yikeke yikeke self-assigned this Jun 3, 2020
@yikeke
Copy link
Contributor

yikeke commented Jun 3, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2020
@yikeke yikeke changed the title Add tips upgrade 4.0 Add tiup upgrade 4.0 Jun 3, 2020
@yikeke yikeke merged commit 53f3a49 into pingcap:master Jun 3, 2020
@yikeke yikeke changed the title Add tiup upgrade 4.0 Add tiups upgrade 4.0 Jun 3, 2020
@yikeke yikeke changed the title Add tiups upgrade 4.0 Add tiup upgrade 4.0 Jun 3, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 3, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 3, 2020
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

cherry pick to release-4.0 in PR #3472

@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

/run-all-tests

sre-bot added a commit that referenced this pull request Jun 3, 2020
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants