Skip to content

tiup/cluster: add usage for check command #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 22, 2020
Merged

tiup/cluster: add usage for check command #3489

merged 5 commits into from
Jun 22, 2020

Conversation

@AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Jun 4, 2020

What is changed, added or deleted? (Required)

Add basic description of subcommand check of TiUP Cluster.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@AstroProfundis AstroProfundis added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-4.0 labels Jun 4, 2020
@AstroProfundis AstroProfundis self-assigned this Jun 4, 2020
@AstroProfundis AstroProfundis requested a review from lucklove June 4, 2020 06:29
lonng
lonng reviewed Jun 5, 2020
View reviewed changes
tiup/tiup-cluster.md
tiup cluster check topology.yml --user tidb -p

# check deploy servers of an existing cluster
tiup cluster check <cluster-name> --cluster
Copy link
Contributor

@lonng lonng Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer tiup cluster check --cluster <cluster-name>

Copy link
Contributor Author

@AstroProfundis AstroProfundis Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both will work, I use this style because our usage string shows cluster <topology.yaml | cluster-name> [flags]

lonng
lonng approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jun 10, 2020
@TomShawn TomShawn requested a review from kissmydb June 10, 2020 03:13
TomShawn
TomShawn reviewed Jun 10, 2020
View reviewed changes
AstroProfundis and others added 4 commits June 11, 2020 20:13
@AstroProfundis @TomShawn
Update tiup/tiup-cluster.md
76bae59 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@AstroProfundis @TomShawn
Update tiup/tiup-cluster.md
31f363f 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@AstroProfundis @TomShawn
Update tiup/tiup-cluster.md
8d81775 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@lucklove
Merge branch 'master' into tiup-cluster-check
7de63a8
lucklove
lucklove approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucklove lucklove merged commit eb68505 into pingcap:master Jun 22, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 22, 2020
@AstroProfundis @ti-srebot
cherry pick pingcap#3489 to release-4.0
1c3bf5b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 22, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2020

cherry pick to release-4.0 in PR #3766

lucklove pushed a commit that referenced this pull request Jun 22, 2020
@ti-srebot @AstroProfundis
cherry pick #3489 to release-4.0 (#3766)
a626f66 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Allen Zhong <zhongbenli@pingcap.com>
@yikeke yikeke assigned yikeke and unassigned AstroProfundis Jun 28, 2020
@yikeke yikeke added size/medium Changes of a medium size. size/small Changes of a small size. and removed size/medium Changes of a medium size. labels Jul 1, 2020
@yikeke yikeke mentioned this pull request Jul 28, 2020
Merged
9 tasks
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 28, 2020
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucklove lucklove lucklove approved these changes

@kissmydb kissmydb Awaiting requested review from kissmydb

+2 more reviewers

@TomShawn TomShawn TomShawn left review comments

@lonng lonng lonng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yikeke yikeke

Labels

size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AstroProfundis @ti-srebot @lonng @lucklove @TomShawn @yikeke