Skip to content

dashboard: convert svg to png #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2020
Merged

dashboard: convert svg to png #3572

merged 3 commits into from
Jun 9, 2020

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 9, 2020

What is changed, added or deleted? (Required)

SVG causes build failure.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ran-huang ran-huang requested a review from YiniXu9506 June 9, 2020 05:29
@ran-huang ran-huang added the translation/doing This PR’s assignee is translating this PR. label Jun 9, 2020
YiniXu9506
YiniXu9506 approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@YiniXu9506 YiniXu9506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor Author

ran-huang commented Jun 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit ebaf9d3 into pingcap:master Jun 9, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 9, 2020
@ran-huang @sre-bot
cherry pick pingcap#3572 to release-4.0
30001ca 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 9, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

cherry pick to release-4.0 in PR #3573

@ran-huang ran-huang deleted the fix-build-failure branch June 9, 2020 06:07
sre-bot added a commit that referenced this pull request Jun 9, 2020
@sre-bot @ran-huang
dashboard: convert svg to png (#3572) (#3573)
0e2d6d6 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@TomShawn TomShawn mentioned this pull request Jun 9, 2020
Merged
5 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 9, 2020
@sre-bot sre-bot mentioned this pull request Jun 9, 2020
Merged
5 tasks
@jiaqizho jiaqizho mentioned this pull request Dec 22, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@YiniXu9506 YiniXu9506 YiniXu9506 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ran-huang @sre-bot @YiniXu9506 @TomShawn