Skip to content

Secure: remove out-dated encryption docs #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2020
Merged

Secure: remove out-dated encryption docs #3622

merged 2 commits into from
Jun 13, 2020

Conversation

@yiwu-arbug
Copy link
Contributor

@yiwu-arbug yiwu-arbug commented Jun 12, 2020 •
edited by yikeke
Loading

Signed-off-by: Yi Wu yiwu@pingcap.com

What is changed, added or deleted? (Required)

The "Enable Stored Data Encryption" document is out-dated (the feature is removed in 4.0.0). The feature is replaced by "Encryption-At-Rest" which document was added in pingcap/docs#2635 but not translated yet.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Secure: remove out-dated encryption docs
766e631 
Signed-off-by: Yi Wu <yiwu@pingcap.com>
@yiwu-arbug yiwu-arbug requested review from hicqu and ran-huang June 12, 2020 21:42
@yikeke yikeke added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Jun 13, 2020
@yikeke
Copy link
Contributor

yikeke commented Jun 13, 2020 •
edited
Loading

Please help translate pingcap/docs#2410 first thing next week, thanks~ @ran-huang

FYI @yiwu-arbug

@yikeke yikeke merged commit 902ec34 into pingcap:master Jun 13, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 13, 2020
@sre-bot
cherry pick pingcap#3622 to release-4.0
77aa38f 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 13, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 13, 2020

cherry pick to release-4.0 in PR #3623

sre-bot added a commit that referenced this pull request Jun 13, 2020
@sre-bot
Secure: remove out-dated encryption docs (#3622) (#3623)
6903e56 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: yiwu-arbug <yiwu@pingcap.com>
@yiwu-arbug yiwu-arbug deleted the enc_outdated branch June 13, 2020 05:25
@yiwu-arbug yiwu-arbug mentioned this pull request Jul 10, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hicqu hicqu Awaiting requested review from hicqu

@ran-huang ran-huang Awaiting requested review from ran-huang

1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yiwu-arbug @yikeke @sre-bot