Skip to content

Conversation

@toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jun 15, 2020

What is changed, added or deleted? (Required)

change data-migration-route.md to migration-overview.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@toutdesuite toutdesuite added needs-cherry-pick-4.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jun 15, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@yikeke yikeke added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jun 15, 2020
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the status/require-change Needs the author to address comments. label Jun 15, 2020
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@toutdesuite toutdesuite added status/can-merge Indicates a PR has been approved by a committer. and removed status/require-change Needs the author to address comments. labels Jun 15, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@toutdesuite toutdesuite removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2020
@toutdesuite
Copy link
Contributor Author

@yikeke PTAL again, thanks

@yikeke
Copy link
Contributor

yikeke commented Jun 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 3014622 into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3671

ti-srebot added a commit that referenced this pull request Jun 16, 2020
* cherry pick #3647 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update migration-overview.md

Co-authored-by: toutdesuite <guizhiluo2014@163.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants