Skip to content

*: fix typo #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2020
Merged

*: fix typo #3653

merged 2 commits into from
Jun 16, 2020

Conversation

@disksing
Copy link
Contributor

@disksing disksing commented Jun 15, 2020 •
edited by TomShawn
Loading

Signed-off-by: disksing i@disksing.com

What is changed, added or deleted? (Required)

Fix 2 typos.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@disksing
*: fix typo
944758d 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing requested a review from HunDunDM June 15, 2020 06:54
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. and removed needs-cherry-pick-2.1 labels Jun 15, 2020
@TomShawn TomShawn self-assigned this Jun 15, 2020
TomShawn
TomShawn approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented Jun 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 16, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 3daa394 into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 16, 2020
@disksing @ti-srebot
cherry pick pingcap#3653 to release-4.0
533b0c7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 16, 2020

cherry pick to release-4.0 in PR #3684

ti-srebot added a commit that referenced this pull request Jun 16, 2020
@ti-srebot @disksing
*: fix typo (#3653) (#3684)
fd4a4c6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: disksing <i@disksing.com>
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@TomShawn TomShawn added translation/no-need No need to translate this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 14, 2020
@TomShawn TomShawn removed their assignment Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@HunDunDM HunDunDM HunDunDM approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@disksing @TomShawn @ti-srebot @HunDunDM @yikeke