Skip to content

cdc: add cyclic replication doc #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 17, 2020
Merged

cdc: add cyclic replication doc #3666

merged 10 commits into from
Jun 17, 2020

Conversation

@overvenus
Copy link
Member

@overvenus overvenus commented Jun 15, 2020

What is changed, added or deleted? (Required)

Add document about TiCDC cyclic replication feature.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A
  • Other reference link(s): N/A

@overvenus
cdc: add cyclic replication doc
5265aaa 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus requested a review from amyangfei June 15, 2020 12:03
@yikeke yikeke requested a review from lilin90 June 15, 2020 12:06
@yikeke yikeke added needs-cherry-pick-4.0 translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 15, 2020
@amyangfei amyangfei mentioned this pull request Jun 16, 2020
Closed
18 tasks
@overvenus
Copy link
Member Author

overvenus commented Jun 16, 2020

PTAL, thanks!

amyangfei
amyangfei reviewed Jun 16, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated
{{< copyable "shell-regular" >}}

```shell
# 在 TiDB 集群 A 上创建表数据表。
Copy link
Contributor

@amyangfei amyangfei Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 在 TiDB 集群 A 上创建表数据表。
# 在 TiDB 集群 A 上创建标记数据表。

ditto for following two comments

ticdc/manage-ticdc.md Outdated
--pd="http://${PD_B_HOST}:${PD_B_PORT}" \
--cyclic-replica-id 2 \
--cyclic-filter-replica-ids 3 \
--cyclic-sync-ddl false
Copy link
Contributor

@amyangfei amyangfei Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里和示例图不一致，B 也是需要开启 sync-ddl 的？

ticdc/manage-ticdc.md Outdated

### 环形同步使用限制

1. 环形复制功能使用到的表急表必须在创建环形同步任务前使用 `cdc cli changefeed cyclic create-marktables` 创建。
Copy link
Contributor

@amyangfei amyangfei Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. 环形复制功能使用到的表急表必须在创建环形同步任务前使用 `cdc cli changefeed cyclic create-marktables` 创建。
1. 环形复制功能使用到的标记表必须在创建环形同步任务前使用 `cdc cli changefeed cyclic create-marktables` 创建。

ticdc/manage-ticdc.md Outdated
3. 开启环形复制的数据表表必须在创建环形同步任务前创建完毕。
4. 开启环形复制后，不能创建一个会被环形同步任务同步的表。
5. 如果想在线 DDL，需要确保：
1. 多个集群中有且仅有一个集群的 CDC(s) 开启了 cyclic-sync-ddl，例如示例中的 A 集群 CDC
Copy link
Contributor

@amyangfei amyangfei Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在线 DDL 是需要保证“构成一个单向同步链表，不能成环” ？

overvenus added 2 commits June 16, 2020 14:28
@overvenus
address comments
2e5df08 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
update command usage
de11b50 
Signed-off-by: Neil Shen <overvenus@gmail.com>
amyangfei
amyangfei approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2020
lilin90
lilin90 requested changes Jun 17, 2020
View reviewed changes
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jun 17, 2020
overvenus and others added 3 commits June 17, 2020 19:58
@overvenus @lilin90
Apply suggestions from code review
4bc3e0e 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@overvenus
complete sentence
3b02b27 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
use "、" instead of ","
7f2c248 
Signed-off-by: Neil Shen <overvenus@gmail.com>
lilin90
lilin90 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 17, 2020
@lilin90
Copy link
Member

lilin90 commented Jun 17, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 17, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit ea44d77 into pingcap:master Jun 17, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 17, 2020
@overvenus @ti-srebot
cherry pick pingcap#3666 to release-4.0
a114674 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 17, 2020

cherry pick to release-4.0 in PR #3700

lilin90 pushed a commit that referenced this pull request Jun 18, 2020
@ti-srebot @overvenus
cherry pick #3666 to release-4.0 (#3700)
0480516 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
@yikeke yikeke added size/large Changes of a large size. and removed status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. labels Jun 19, 2020
@TomShawn TomShawn mentioned this pull request Jul 8, 2020
Merged
5 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 8, 2020
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

+1 more reviewer

@amyangfei amyangfei amyangfei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@overvenus @lilin90 @ti-srebot @amyangfei @yikeke @TomShawn