Skip to content

cdc: add software and hardware recommendation #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2020
Merged

cdc: add software and hardware recommendation #3676

merged 5 commits into from
Jun 17, 2020

Conversation

@overvenus
Copy link
Member

@overvenus overvenus commented Jun 16, 2020

What is changed, added or deleted? (Required)

Add software and hardware recommendation for TiCDC.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A
  • Other reference link(s): N/A

@overvenus
cdc: add software and hardware recommendation
ab02361 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@github-actions github-actions bot requested a review from TomShawn June 16, 2020 06:08
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 16, 2020
@amyangfei amyangfei mentioned this pull request Jun 16, 2020
Closed
18 tasks
@TomShawn TomShawn requested a review from amyangfei June 16, 2020 06:25
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 16, 2020
amyangfei
amyangfei reviewed Jun 16, 2020
View reviewed changes
amyangfei
amyangfei approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT1 Indicates that a PR has LGTM 1. and removed status/PTAL This PR is ready for reviewing. labels Jun 17, 2020
TomShawn
TomShawn reviewed Jun 17, 2020
View reviewed changes
@overvenus @TomShawn
Apply suggestions from code review
022f41b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Jun 17, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 17, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 17, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 78cb193 into master Jun 17, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 17, 2020
@overvenus @ti-srebot
cherry pick pingcap#3676 to release-4.0
e08ee00 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 17, 2020

cherry pick to release-4.0 in PR #3699

ti-srebot added a commit that referenced this pull request Jun 17, 2020
@ti-srebot @overvenus
cdc: add software and hardware recommendation (#3676) (#3699)
b0590b7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 16, 2020
@ran-huang ran-huang mentioned this pull request Jul 16, 2020
Merged
5 tasks
@ran-huang ran-huang deleted the cdc/soft-hard-ware branch July 16, 2020 12:57
@ti-srebot ti-srebot mentioned this pull request Jul 30, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@amyangfei amyangfei amyangfei approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ran-huang ran-huang

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@overvenus @ti-srebot @amyangfei @TomShawn @yikeke @ran-huang