Skip to content

tiup: update pd status description #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2020
Merged

tiup: update pd status description #3685

merged 3 commits into from
Jun 22, 2020

Conversation

@baurine
Copy link
Contributor

@baurine baurine commented Jun 16, 2020

What is changed, added or deleted? (Required)

Update the PD status description, change 'Healthy' to 'Up'

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@github-actions github-actions bot requested a review from TomShawn June 16, 2020 09:34
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 16, 2020
@baurine
Copy link
Contributor Author

baurine commented Jun 16, 2020

@lonng @AstroProfundis PTAL, thanks!

@baurine baurine force-pushed the update-pd-status branch from a7a33aa to 26a831f Compare June 16, 2020 09:38
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-4.0 and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 17, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 18, 2020

@TomShawn, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 20, 2020

@TomShawn, PTAL.

@TomShawn TomShawn requested review from AstroProfundis and lonng June 22, 2020 02:36
lonng
lonng approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented Jun 22, 2020

LGTM

@baurine baurine merged commit c6f613f into master Jun 22, 2020
@baurine baurine deleted the update-pd-status branch June 22, 2020 05:15
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 22, 2020
@baurine @ti-srebot
cherry pick pingcap#3685 to release-4.0
fe166d6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 22, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2020

cherry pick to release-4.0 in PR #3759

@yikeke yikeke assigned yikeke and unassigned ran-huang Jun 22, 2020
baurine added a commit that referenced this pull request Jun 22, 2020
@ti-srebot @baurine
cherry pick #3685 to release-4.0 (#3759)
8fefc62 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 23, 2020
@yikeke yikeke mentioned this pull request Jun 23, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomShawn TomShawn Awaiting requested review from TomShawn

@AstroProfundis AstroProfundis Awaiting requested review from AstroProfundis

1 more reviewer

@lonng lonng lonng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yikeke yikeke

Labels

status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@baurine @ti-srebot @TomShawn @lonng @yikeke @ran-huang