Skip to content

add tiup ssh handshake failed faq #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 19, 2020
Merged

add tiup ssh handshake failed faq #3701

merged 7 commits into from
Jun 19, 2020

Conversation

@wentaojin
Copy link
Contributor

@wentaojin wentaojin commented Jun 18, 2020 •
edited by yikeke
Loading

add tiup ssh handshake failed faq

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@wentaojin
add tiup ssh handshake failed faq
173c6a6 
add tiup ssh handshake failed faq
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Jun 18, 2020
TomShawn
TomShawn reviewed Jun 18, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jun 18, 2020
View reviewed changes
@TomShawn TomShawn requested a review from lonng June 18, 2020 14:08
@TomShawn TomShawn self-assigned this Jun 18, 2020
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jun 18, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jun 18, 2020

@wentaojin Does this change apply to master?

TomShawn and others added 2 commits June 19, 2020 10:37
@TomShawn
Merge branch 'release-4.0' into patch-1
4b9853b
@wentaojin @TomShawn
Update tiup/tiup-faq.md
84f4873 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@wentaojin
Copy link
Contributor Author

wentaojin commented Jun 19, 2020

@wentaojin Does this change apply to master?

sure，it only can meet ssh error when tiup is using @TomShawn

wentaojin and others added 2 commits June 19, 2020 12:12
@wentaojin @TomShawn
Update tiup/tiup-faq.md
26b23e2 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Merge branch 'release-4.0' into patch-1
808972c
TomShawn
TomShawn reviewed Jun 19, 2020
View reviewed changes
lonng
lonng approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the requires-followup This PR requires a follow-up task after being merged. label Jun 19, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jun 19, 2020 •
edited
Loading

@wentaojin Does this change apply to master?

sure，it only can meet ssh error when tiup is using @TomShawn

Could you create another PR to make the change in master? It is recommended to create PRs based on master and use the cherry-pick labels to easily cherry-pick changes to other release branches. The other way around currently does not work out.

@wentaojin
Copy link
Contributor Author

wentaojin commented Jun 19, 2020

@wentaojin Does this change apply to master?

sure，it only can meet ssh error when tiup is using @TomShawn

Could you create another PR to make the change in master? It is recommended to create PRs based on master and use the cherry-pick labels to easily cherry-pick changes to other release branches. The other way around currently does not work out.

ok，has created PR to master @TomShawn

@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Jun 19, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jun 19, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 19, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 19, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit a4fdd0c into pingcap:release-4.0 Jun 19, 2020
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@wentaojin wentaojin mentioned this pull request Jun 28, 2020
Merged
5 tasks
@yikeke yikeke added the type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. label Jun 28, 2020
@TomShawn TomShawn added translation/no-need No need to translate this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 14, 2020
@TomShawn TomShawn removed their assignment Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TomShawn TomShawn TomShawn left review comments

@lonng lonng lonng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/no-need No need to translate this PR. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wentaojin @TomShawn @ti-srebot @lonng @yikeke