Skip to content

Add more faqs in TiCDC #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 22, 2020
Merged

Add more faqs in TiCDC #3723

merged 6 commits into from
Jun 22, 2020

Conversation

@amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Jun 19, 2020

What is changed, added or deleted? (Required)

  • Add timezone issue in faq
  • Add Ordering guarantees and transaction guarantees
  • Fix some errors in command sample

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@amyangfei amyangfei mentioned this pull request Jun 19, 2020
Closed
18 tasks
@amyangfei amyangfei added the status/PTAL This PR is ready for reviewing. label Jun 19, 2020
@amyangfei
Copy link
Contributor Author

amyangfei commented Jun 19, 2020

PTAL @leoppro @overvenus

overvenus
overvenus reviewed Jun 19, 2020
View reviewed changes
ticdc/troubleshoot-ticdc.md Outdated
{{< copyable "shell-regular" >}}

```shell
how variables like '%time_zone%';
Copy link
Member

@overvenus overvenus Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
how variables like '%time_zone%';
show variables like '%time_zone%';

ticdc/troubleshoot-ticdc.md
{{< copyable "shell-regular" >}}

```shell
mysql_tzinfo_to_sql /usr/share/zoneinfo | mysql -u root mysql -p
Copy link
Member

@overvenus overvenus Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the "mysql_tzinfo_to_sql"?

Copy link
Contributor Author

@amyangfei amyangfei Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a link to MySQL document

overvenus
overvenus approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zier-one
zier-one approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jun 19, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 21, 2020

@overvenus, @leoppro, PTAL.

@TomShawn TomShawn added the size/medium Changes of a medium size. label Jun 22, 2020
TomShawn
TomShawn reviewed Jun 22, 2020
View reviewed changes
@TomShawn
Copy link
Contributor

TomShawn commented Jun 22, 2020

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented Jun 22, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 038ea7b into pingcap:master Jun 22, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 22, 2020
@amyangfei @ti-srebot
cherry pick pingcap#3723 to release-4.0
3934825 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 22, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2020

cherry pick to release-4.0 in PR #3751

@amyangfei amyangfei deleted the refine-cdc-docs branch June 22, 2020 05:15
ti-srebot added a commit that referenced this pull request Jun 23, 2020
@ti-srebot @amyangfei
Add more faqs in TiCDC (#3723) (#3751)
90b43ac 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: amyangfei <amyangfei@gmail.com>
@ran-huang ran-huang self-assigned this Jul 30, 2020
@ran-huang ran-huang added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 30, 2020
@ran-huang ran-huang mentioned this pull request Jul 31, 2020
Merged
9 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 31, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 7, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

+2 more reviewers

@TomShawn TomShawn TomShawn left review comments

@zier-one zier-one zier-one approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ran-huang ran-huang

Labels

size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amyangfei @ti-srebot @TomShawn @overvenus @zier-one @ran-huang