Skip to content

*: add warnings #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2020
Merged

*: add warnings #3752

merged 2 commits into from
Jun 22, 2020

Conversation

@jackysp
Copy link
Member

@jackysp jackysp commented Jun 22, 2020 •
edited
Loading

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@jackysp
*: add warnings
dfaefd6 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@yikeke yikeke requested a review from kissmydb June 22, 2020 04:35
yikeke
yikeke approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Jun 22, 2020
@yikeke yikeke assigned TomShawn and yikeke and unassigned TomShawn Jun 22, 2020
kissmydb
kissmydb approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit c8f817f into pingcap:master Jun 22, 2020
@yikeke yikeke added the size/small Changes of a small size. label Jun 22, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 22, 2020
@jackysp @ti-srebot
cherry pick pingcap#3752 to release-4.0
0c73d02 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 22, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2020

cherry pick to release-4.0 in PR #3769

ti-srebot added a commit that referenced this pull request Jun 22, 2020
@ti-srebot @jackysp
*: add warnings (#3752) (#3769)
76d9a8f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Jack Yu <yusp@pingcap.com>
@yikeke yikeke mentioned this pull request Jun 23, 2020
Merged
5 tasks
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 23, 2020
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kissmydb kissmydb kissmydb approved these changes

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yikeke yikeke

Labels

size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jackysp @ti-srebot @kissmydb @yikeke @TomShawn