Skip to content

Fix typo in literal values #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 1, 2020
Merged

Fix typo in literal values #3845

merged 4 commits into from
Jul 1, 2020

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jul 1, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Fix typo in literal values

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/no-need No need to translate this PR. size/small Changes of a small size. needs-cherry-pick-3.1 labels Jul 1, 2020
@TomShawn TomShawn requested a review from ran-huang July 1, 2020 08:06
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jul 1, 2020
@TomShawn TomShawn mentioned this pull request Jul 1, 2020
Merged
5 tasks
@TomShawn TomShawn removed status/PTAL This PR is ready for reviewing. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 1, 2020
@ran-huang
Copy link
Contributor

ran-huang commented Jul 1, 2020

@TomShawn LGTM.
Please don't merge it yet. I'll fix other typos in this PR.

@ran-huang
Copy link
Contributor

ran-huang commented Jul 1, 2020

@TomShawn PTAL at this commit 624966b. Thanks~

@TomShawn
Copy link
Contributor Author

TomShawn commented Jul 1, 2020 •
edited
Loading

@TomShawn PTAL at this commit 624966b. Thanks~

LGTM, thanks!

@ran-huang
Copy link
Contributor

ran-huang commented Jul 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 1, 2020

/run-all-tests

@ran-huang ran-huang merged commit b72d1fd into master Jul 1, 2020
@ran-huang ran-huang deleted the TomShawn-patch-2 branch July 1, 2020 13:08
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 1, 2020
@TomShawn @ti-srebot
cherry pick pingcap#3845 to release-3.0
0bcf916 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 1, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 1, 2020

cherry pick to release-3.0 in PR #3851

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 1, 2020
@TomShawn @ti-srebot
cherry pick pingcap#3845 to release-3.1
91e4b73 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 1, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 1, 2020

cherry pick to release-3.1 in PR #3852

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 1, 2020
@TomShawn @ti-srebot
cherry pick pingcap#3845 to release-4.0
fc84316 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 1, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 1, 2020

cherry pick to release-4.0 in PR #3853

ti-srebot added a commit that referenced this pull request Jul 1, 2020
@ti-srebot @TomShawn
Fix typo in literal values (#3845) (#3851)
992feab 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
ti-srebot added a commit that referenced this pull request Jul 1, 2020
@ti-srebot @TomShawn
Fix typo in literal values (#3845) (#3853)
6f57f57 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
ti-srebot added a commit that referenced this pull request Jul 1, 2020
@ti-srebot @TomShawn
Fix typo in literal values (#3845) (#3852)
3da368a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @ran-huang @ti-srebot