Skip to content

Conversation

@ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

  • Add a doc for the "table filter" feature shared by all new TiDB ecosystem tools
  • Update related contents for BR and TiDB Lightning

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs This PR is translated from a PR in pingcap/docs. size/large Changes of a large size. needs-cherry-pick-3.1 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Jul 7, 2020
@ran-huang ran-huang requested review from kennytm and yikeke July 7, 2020 11:09
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Co-authored-by: kennytm <kennytm@gmail.com>
@overvenus
Copy link
Member

@ran-huang
Copy link
Contributor Author

@ran-huang ran-huang mentioned this pull request Jul 9, 2020
5 tasks
@yikeke yikeke requested review from TomShawn and removed request for yikeke July 9, 2020 07:53
@yikeke
Copy link
Contributor

yikeke commented Jul 9, 2020

Please help review this PR, thanks~ @TomShawn

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
Copy link
Contributor Author

@TomShawn PTAL again, thanks~

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@TomShawn,Thanks for your review.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 3925

@ran-huang ran-huang merged commit a4c0315 into pingcap:master Jul 13, 2020
@ran-huang ran-huang deleted the table-filter branch July 13, 2020 02:43
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3949

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3950

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3951

ran-huang added a commit that referenced this pull request Jul 13, 2020
* cherry pick #3916 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* change aliases

Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Jul 13, 2020
* cherry pick #3916 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict and apply version specific changes

* fix a deadlink

* Delete tidb-lightning-table-filter.md

Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Jul 13, 2020
* cherry pick #3916 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update TOC.md

* resolve conflict and apply version-specific changes

* Delete manage-ticdc.md

* fix a deadlink

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants