Skip to content

br, sql-statements: document BACKUP, RESTORE and SHOW [BACKUPS|RESTORES] #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 13, 2020
Merged

br, sql-statements: document BACKUP, RESTORE and SHOW [BACKUPS|RESTORES] #3925

merged 12 commits into from
Jul 13, 2020

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jul 8, 2020

What is changed, added or deleted? (Required)

  • Add a doc for BR storages.

  • Add docs for 3 SQL statements:

    • BACKUP
    • RESTORE
    • SHOW BACKUPS

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-4.0 size/large Changes of a large size. labels Jul 8, 2020
@ran-huang ran-huang marked this pull request as ready for review July 9, 2020 08:24
@ran-huang ran-huang requested review from kennytm and yikeke July 9, 2020 08:24
@yikeke yikeke requested review from 3pointer and TomShawn and removed request for yikeke July 9, 2020 08:34
@yikeke
Copy link
Contributor

yikeke commented Jul 9, 2020

Please help review this PR. @TomShawn

TomShawn
TomShawn reviewed Jul 9, 2020
View reviewed changes
3pointer
3pointer reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 10, 2020

@3pointer, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

ran-huang and others added 2 commits July 10, 2020 11:41
@ran-huang @TomShawn
Apply suggestions from code review
7965e25 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
address comments; update pic
37bc944
@ran-huang
Copy link
Contributor Author

ran-huang commented Jul 10, 2020

@TomShawn All comments addressed. PTAL, thanks~

TomShawn
TomShawn reviewed Jul 10, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 10, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 10, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 10, 2020

@TomShawn,Thanks for your review.

TomShawn
TomShawn reviewed Jul 13, 2020
View reviewed changes
@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 13, 2020

/run-all-tests

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 13, 2020

/run-all-tests

@ran-huang ran-huang merged commit 2047309 into pingcap:master Jul 13, 2020
@ran-huang ran-huang deleted the sql-backup-restore branch July 13, 2020 05:05
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3925 to release-4.0
61af6ce 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 13, 2020

cherry pick to release-4.0 in PR #3953

ran-huang added a commit that referenced this pull request Jul 13, 2020
@ti-srebot @ran-huang
cherry pick #3925 to release-4.0 (#3953)
db85926 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@kennytm kennytm mentioned this pull request Feb 22, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@kennytm kennytm Awaiting requested review from kennytm

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ran-huang @yikeke @ti-srebot @kennytm @3pointer @TomShawn