Skip to content

ticdc: update the doc link of filter rule #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2020
Merged

ticdc: update the doc link of filter rule #3965

merged 4 commits into from
Jul 30, 2020

Conversation

@zier-one
Copy link
Contributor

@zier-one zier-one commented Jul 14, 2020

What is changed, added or deleted? (Required)

update the doc link of filter rule

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@zier-one
Copy link
Contributor Author

zier-one commented Jul 14, 2020

@amyangfei PTAL

@zier-one zier-one mentioned this pull request Jul 14, 2020
Merged
amyangfei
amyangfei approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 14, 2020

@amyangfei,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

zier-one
zier-one commented Jul 14, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated

# 过滤器规则
# 过滤规则语法：https://github.com/pingcap/tidb-tools/tree/master/pkg/table-filter#syntax
# 过滤规则语法：https://docs.pingcap.com/zh/tidb/stable/table-filter
Copy link
Contributor Author

@zier-one zier-one Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 过滤规则语法：https://docs.pingcap.com/zh/tidb/stable/table-filter
# 过滤规则语法：https://docs.pingcap.com/zh/tidb/stable/table-filter#%E8%A1%A8%E5%BA%93%E8%BF%87%E6%BB%A4%E8%AF%AD%E6%B3%95

@zier-one
Copy link
Contributor Author

zier-one commented Jul 15, 2020

@TomShawn PTAL

TomShawn
TomShawn reviewed Jul 15, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2020
View reviewed changes
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Jul 15, 2020
@TomShawn TomShawn self-assigned this Jul 15, 2020
@lilin90 lilin90 added status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. labels Jul 30, 2020
lilin90 and others added 2 commits July 30, 2020 21:15
@lilin90
Merge branch 'master' into refine_cdc_doc
8be210a
@lilin90 @TomShawn
Apply suggestions from code review
46185c1 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
lilin90
lilin90 approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2020
@lilin90 lilin90 merged commit 8e46d40 into pingcap:master Jul 30, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 30, 2020
@ti-srebot
cherry pick pingcap#3965 to release-4.0
e6bdccc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 30, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 30, 2020

cherry pick to release-4.0 in PR #4134

ti-srebot added a commit that referenced this pull request Jul 30, 2020
@ti-srebot
ticdc: update the doc link of filter rule (#3965) (#4134)
2a9aed7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: leoppro <zhaoyilin@pingcap.com>
@TomShawn TomShawn assigned Joyinqin and unassigned TomShawn Aug 11, 2020
@Joyinqin
Copy link
Contributor

Joyinqin commented Aug 13, 2020

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 13, 2020
@Joyinqin
Copy link
Contributor

Joyinqin commented Aug 13, 2020

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Aug 13, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 13, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

+2 more reviewers

@TomShawn TomShawn TomShawn left review comments

@amyangfei amyangfei amyangfei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zier-one @ti-srebot @Joyinqin @amyangfei @lilin90 @TomShawn