Skip to content

faq: update descriptions about deploying TiDB on cloud (#4006) #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

faq: update descriptions about deploying TiDB on cloud (#4006) #4020

merged 1 commit into from
Jul 21, 2020

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 21, 2020

cherry-pick #4006 to release-3.0

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

@TomShawn @ti-srebot
cherry pick pingcap#4006 to release-3.0
df1facf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2020
Merged
5 tasks
@ti-srebot ti-srebot added size/small Changes of a small size. type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR. type/bugfix This PR fixes a bug. labels Jul 21, 2020
@ti-srebot ti-srebot requested a review from lilin90 July 21, 2020 08:57
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 21, 2020

@TomShawn please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs-cn/invitations

TomShawn
TomShawn approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Jul 21, 2020
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 21, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 824a735 into pingcap:release-3.0 Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 Awaiting requested review from lilin90

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-srebot @TomShawn