Skip to content

faq, sql-statements: update docs #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 11, 2020
Merged

faq, sql-statements: update docs #4111

merged 11 commits into from
Aug 11, 2020

Conversation

@Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Jul 29, 2020

What is changed, added or deleted? (Required)

Fix some small errors in the FAQ and sql-statements guide

  • The wording on sql-mode changing was a bit cryptic.
  • The SET sql statement now points out differences from MySQL.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Jul 30, 2020

/cc TomShawn,zz-jason

@ti-srebot ti-srebot requested review from TomShawn and zz-jason July 30, 2020 01:53
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Jul 30, 2020

/label needs-cherry-pick-4.0, version-specific-changes-required, translation/from-docs

@ti-srebot ti-srebot added needs-cherry-pick-4.0 translation/from-docs This PR is translated from a PR in pingcap/docs. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Jul 30, 2020
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Aug 3, 2020

/label status/PTAL

@ti-srebot ti-srebot added the status/PTAL This PR is ready for reviewing. label Aug 3, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 5, 2020

@zz-jason, @TomShawn, PTAL.

TomShawn
TomShawn reviewed Aug 5, 2020
View reviewed changes
Joyinqin and others added 2 commits August 5, 2020 15:38
@Joyinqin @TomShawn
Apply suggestions from code review
35604d9 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin @TomShawn
Apply suggestions from code review
6027571 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

TomShawn commented Aug 6, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 7, 2020

@TomShawn, @zz-jason, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 9, 2020

@TomShawn, @zz-jason, PTAL.

zz-jason
zz-jason reviewed Aug 11, 2020
View reviewed changes
zz-jason
zz-jason approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 11, 2020
@TomShawn TomShawn merged commit 32de02c into pingcap:master Aug 11, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 11, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#4111 to release-4.0
fe70d7d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 11, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 11, 2020

cherry pick to release-4.0 in PR #4235

ti-srebot added a commit that referenced this pull request Aug 11, 2020
@ti-srebot @Joyinqin @TomShawn
faq, sql-statements: update docs (#4111) (#4235)
3d3c7cd 
* cherry pick #4111 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update sql-faq.md

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin Joyinqin mentioned this pull request Aug 12, 2020
Merged
9 tasks
This was referenced Aug 12, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

+2 more reviewers

@TomShawn TomShawn TomShawn left review comments

@zz-jason zz-jason zz-jason approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joyinqin @ti-srebot @TomShawn @zz-jason