Skip to content

Update character-set-and-collation.md #4193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 10, 2020
Merged

Update character-set-and-collation.md #4193

merged 5 commits into from
Aug 10, 2020

Conversation

@ireneontheway
Copy link
Contributor

@ireneontheway ireneontheway commented Aug 4, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway ireneontheway added translation/from-docs This PR is translated from a PR in pingcap/docs. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 special-week PR from Document Special Week. labels Aug 4, 2020
@ireneontheway ireneontheway requested review from a user and yikeke August 4, 2020 12:47
@ghost
Copy link

ghost commented Aug 4, 2020

Sorry, I can't review cn documents :-) @bb7133 PTAL

@yikeke yikeke requested review from wjhuang2016 and removed request for a user August 5, 2020 02:18
yikeke
yikeke reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. Good job!

@ireneontheway @yikeke
Apply suggestions from code review
9bf8066 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 7, 2020

@yikeke, @wjhuang2016, PTAL.

yikeke
yikeke approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 7, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 9, 2020

@yikeke, @wjhuang2016, PTAL.

wjhuang2016
wjhuang2016 reviewed Aug 10, 2020
View reviewed changes
character-set-and-collation.md Outdated

## TiDB 中的 `utf8` 和 `ut8mb4`

MySQL 限制字符集 `utf8` 为最多 3 个字节。这足以在基本多语言平面 (BMP) 中存储字符，但不足以存储表情符号等字符。因此，建议改用字符集`utf8mb4`。
Copy link
Member

@wjhuang2016 wjhuang2016 Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这足以存储在基本多语言平面 (BMP) 中的字符，但不足以存储表情符号等字符。

Copy link
Contributor Author

@ireneontheway ireneontheway Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

wjhuang2016
wjhuang2016 reviewed Aug 10, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 10, 2020

@wjhuang2016,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ireneontheway ireneontheway merged commit 2c34b20 into pingcap:master Aug 10, 2020
@ireneontheway ireneontheway deleted the character-set-and-collection branch August 10, 2020 03:20
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 10, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#4193 to release-4.0
3da508e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 10, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 10, 2020

cherry pick to release-4.0 in PR #4229

ireneontheway added a commit that referenced this pull request Aug 10, 2020
@ti-srebot @ireneontheway
cherry pick #4193 to release-4.0 (#4229)
52faf62 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

+1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

special-week PR from Document Special Week. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ireneontheway @ti-srebot @wjhuang2016 @yikeke