Skip to content

add tiup deployment prompt in ticdc docs #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 5, 2020
Merged

add tiup deployment prompt in ticdc docs #4199

merged 5 commits into from
Aug 5, 2020

Conversation

@lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Aug 5, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@lichunzhu lichunzhu changed the title add tiup deployment docs in ticdc add tiup deployment prompt in ticdc docs Aug 5, 2020
@lichunzhu
Copy link
Contributor Author

lichunzhu commented Aug 5, 2020

/cc yikeke

@ti-srebot ti-srebot requested a review from yikeke August 5, 2020 07:49
@yikeke yikeke added needs-cherry-pick-4.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Aug 5, 2020
yikeke
yikeke reviewed Aug 5, 2020
View reviewed changes
lichunzhu
lichunzhu commented Aug 5, 2020
View reviewed changes
@yikeke @lichunzhu
Update ticdc/ticdc-overview.md
43616cc 
Co-authored-by: Chunzhu Li <lichunzhu@pingcap.com>
yikeke
yikeke approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2020
@yikeke yikeke merged commit 92445a6 into pingcap:master Aug 5, 2020
@lichunzhu lichunzhu deleted the refineTiUPCDC branch August 5, 2020 08:34
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 5, 2020
@lichunzhu @ti-srebot
cherry pick pingcap#4199 to release-4.0
f420cb5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 5, 2020

cherry pick to release-4.0 in PR #4200

ti-srebot added a commit that referenced this pull request Aug 5, 2020
@ti-srebot @lichunzhu
add tiup deployment prompt in ticdc docs (#4199) (#4200)
1edf830 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
@Joyinqin Joyinqin mentioned this pull request Aug 13, 2020
Merged
9 tasks
@Joyinqin
Copy link
Contributor

Joyinqin commented Aug 13, 2020

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 13, 2020
@Joyinqin
Copy link
Contributor

Joyinqin commented Aug 13, 2020

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Aug 13, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lichunzhu @ti-srebot @Joyinqin @yikeke