Skip to content

improve location-awareness in 3.1 (#4532) #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2020
Merged

improve location-awareness in 3.1 (#4532) #4537

merged 2 commits into from
Sep 17, 2020

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 17, 2020

cherry-pick #4532 to release-3.0

What is changed, added or deleted? (Required)

Cherry-pick #3174 to v3.1/v3.0/v2.1

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn @ti-srebot
cherry pick pingcap#4532 to release-3.0
69e6cc1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
9 tasks
@ti-srebot ti-srebot added status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Sep 17, 2020
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Sep 17, 2020

@TomShawn please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs-cn/invitations

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Sep 17, 2020

@disksing,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Sep 17, 2020
@TomShawn TomShawn merged commit bdd6db0 into pingcap:release-3.0 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disksing disksing disksing approved these changes

@ran-huang ran-huang Awaiting requested review from ran-huang

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-srebot @disksing @TomShawn