Skip to content

statistics: add docs for version 2#5164

Merged
ran-huang merged 11 commits intopingcap:masterfrom
winoros:stats-ver2
Dec 30, 2020
Merged

statistics: add docs for version 2#5164
ran-huang merged 11 commits intopingcap:masterfrom
winoros:stats-ver2

Conversation

@winoros
Copy link
Copy Markdown
Member

@winoros winoros commented Dec 24, 2020

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add descption about the analyze's changes based on the variable tidb_analyze_version

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added size/medium Changes of a medium size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. v5.0 This PR/issue applies to TiDB v5.0 labels Dec 24, 2020
time-and-fate
time-and-fate reviewed Dec 24, 2020
View reviewed changes
statistics.md Outdated
| repeats | 最大值出现的次数 |
| lower_bound | 最小值 |
| upper_bound | 最大值 |
| ndv | 不同值的个数，当 analyze version 为 1 时，该值没有实际意义，因此会有 count 不为 0，但 ndv 为 0 的情况 |
Copy link
Copy Markdown
Member

@time-and-fate time-and-fate Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接说 version 为 1 时恒为 0 没有意义是不是会清晰一些？

Copy link
Copy Markdown
Contributor

@qw4990 qw4990 Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

statistics.md Outdated
Comment on lines +13 to +14
| 列的Count-Min Sketch | √ | × |
| 索引的Count-Min Sketch | √ | × |
Copy link
Copy Markdown
Member

@time-and-fate time-and-fate Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里似乎中英文之间要空格

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Dec 25, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Dec 26, 2020

@time-and-fate, @qw4990, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Dec 27, 2020

@winoros, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Dec 28, 2020

@time-and-fate, @qw4990, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Dec 29, 2020

@winoros, please update your pull request.

This was referenced Dec 29, 2020
Closed
Closed
qw4990
qw4990 reviewed Dec 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address existed comments @winoros

time-and-fate
time-and-fate reviewed Dec 30, 2020
View reviewed changes
time-and-fate
time-and-fate reviewed Dec 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Dec 30, 2020

@time-and-fate, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn assigned ran-huang and unassigned CharLotteiu Dec 30, 2020
@TomShawn TomShawn requested a review from ran-huang December 30, 2020 05:46
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Dec 30, 2020
ran-huang
ran-huang reviewed Dec 30, 2020
View reviewed changes
ran-huang
ran-huang reviewed Dec 30, 2020
View reviewed changes
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Dec 30, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2020
@ran-huang
fix 404
0367165 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang
fix 404 link
20fd4eb 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang merged commit 6898cf4 into pingcap:master Dec 30, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Dec 30, 2020
@winoros @ti-srebot
cherry pick pingcap#5164 to release-5.0
20cd92c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 30, 2020
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Dec 30, 2020

cherry pick to release-5.0 in PR #5217

ran-huang pushed a commit that referenced this pull request Dec 30, 2020
@ti-srebot @winoros
cherry pick #5164 to release-5.0 (#5217)
4c27d15 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Yiding Cui <winoros@gmail.com>
@ran-huang ran-huang mentioned this pull request Dec 30, 2020
Merged
10 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 30, 2020
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Dec 30, 2020
@ti-srebot ti-srebot mentioned this pull request Dec 30, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 left review comments

@time-and-fate time-and-fate time-and-fate left review comments

+1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ran-huang ran-huang

Labels

size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@winoros @ti-srebot @qw4990 @time-and-fate @ran-huang @CharLotteiu @TomShawn