update async commit related configurations#5181
Merged
TomShawn merged 6 commits intopingcap:masterfrom Dec 28, 2020
Merged
Conversation
sticnarf
force-pushed
the
async-commit
branch
2 times, most recently
from
1a920c0 to
209c995
Compare
Contributor
|
@sticnarf Please involve a technical review~ |
TomShawn
added
size/medium
sticnarf
force-pushed
the
async-commit
branch
3 times, most recently
from
d7a242d to
0984d7a
Compare
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
force-pushed
the
async-commit
branch
from
0984d7a to
e6d19e6
Compare
Contributor
Author
|
PTAL @youjiali1995 |
Contributor
|
@youjiali1995, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack). |
TomShawn
reviewed
Dec 28, 2020
TomShawn
reviewed
Dec 28, 2020
TomShawn
reviewed
Dec 28, 2020
TomShawn
reviewed
Dec 28, 2020
9 tasks
9 tasks
scsldb
reviewed
Dec 30, 2020
| > 当前该功能为实验特性，不建议在生产环境中使用。目前存在已知问题有： | ||
| > | ||
| > + 暂时与 [TiCDC](/ticdc/ticdc-overview.md) 不兼容，可能导致 TiCDC 运行不正常。 | ||
| > + 暂时与 [Compaction Filter](/tikv-configuration-file.md#enable-compaction-filter) 不兼容，共同使用时有小概率发生写丢失。 |
Contributor
There was a problem hiding this comment.
当前该功能为实验特性，不建议在生产环境中使用。目前存在已知问题有
修改成：
实验特性，不推荐在生产环境中使用。目前已知不兼容性，如下：
本特性与 TiDB Binlog 不兼容，开启 TiDB Binlog 时本配置将不生效
修改成：开启 TiDB Binlog 时，该变量值不生效。
Contributor
|
/label translation/done |
ti-srebot
added
the
translation/done
Contributor
|
/unlabel translation/doing |
ti-srebot
removed
the
translation/doing
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Async commit and 1PC configurations have been moved from config file to system variables.
And there are known correctness issues about 1PC, so 1PC content is hidden.
Which TiDB version(s) do your changes apply to? (Required)
Do your changes match any of the following descriptions?