Skip to content

topsql: update tidb topsql system variable doc#8755

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
crazycs520:topsql-var-doc
Mar 25, 2022
Merged

topsql: update tidb topsql system variable doc#8755
ti-chi-bot merged 6 commits intopingcap:masterfrom
crazycs520:topsql-var-doc

Conversation

@crazycs520
Copy link
Copy Markdown
Contributor

@crazycs520 crazycs520 commented Mar 24, 2022

Signed-off-by: crazycs520 crazycs520@gmail.com

What is changed, added or deleted? (Required)

update tidb topsql system variable

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

pingcap/tidb#31599

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@crazycs520
topsql: update tidb topsql system variable
63d4e1d 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SunRunAway
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 24, 2022 08:37
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2022
@crazycs520
update
88db17e 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@TomShawn TomShawn requested review from qiancai and removed request for TomShawn March 24, 2022 10:19
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 24, 2022
@ran-huang ran-huang added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0. labels Mar 24, 2022
@TomShawn TomShawn added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. and removed area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Mar 24, 2022
@TomShawn TomShawn requested a review from breezewish March 24, 2022 11:23
@qiancai qiancai requested a review from SunRunAway March 24, 2022 11:27
qiancai
qiancai reviewed Mar 24, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazycs520 PTAL 在 Top SQL 文档里是不是也可以介绍下这两个配置呢？

crazycs520 and others added 3 commits March 25, 2022 10:59
@crazycs520 @qiancai
Update system-variables.md
d76784a 
Co-authored-by: Grace Cai <qqzczy@126.com>
@crazycs520 @qiancai
Update system-variables.md
b5073fa 
Co-authored-by: Grace Cai <qqzczy@126.com>
@crazycs520 @qiancai
Update system-variables.md
7f3b661 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
SunRunAway
SunRunAway reviewed Mar 25, 2022
View reviewed changes
@shichun-0415 shichun-0415 self-requested a review March 25, 2022 06:32
qiancai
qiancai approved these changes Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 25, 2022
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Mar 25, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 25, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8aae9db

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@ti-chi-bot ti-chi-bot merged commit bd0dda7 into pingcap:master Mar 25, 2022
@qiancai qiancai mentioned this pull request Mar 29, 2022
Merged
16 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai approved these changes

@breezewish breezewish Awaiting requested review from breezewish

+2 more reviewers

@SunRunAway SunRunAway SunRunAway approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qiancai qiancai

Labels

area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@crazycs520 @ti-chi-bot @qiancai @SunRunAway @shichun-0415 @TomShawn @ran-huang