Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Conversation

@ireneontheway
Copy link
Contributor

What is changed, added or deleted? (Required)

add a notice about topology example for scale-out via TiUP.

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

@ireneontheway ireneontheway added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/from-zh This PR is translated from a PR in docs-dm/zh. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. labels Sep 9, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2020
@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 9, 2020
@yikeke
Copy link
Contributor

yikeke commented Sep 9, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 9, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 368

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit bed3085 into pingcap:master Sep 9, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Sep 9, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #374

ti-srebot added a commit that referenced this pull request Sep 9, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-zh This PR is translated from a PR in docs-dm/zh.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants