Skip to content

cloud dm: delete compression format for parquet #13810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

cloud dm: delete compression format for parquet #13810

wants to merge 2 commits into from

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Jun 8, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Deleted the compression format for Parquet because Parquet does not support it.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Jun 8, 2023
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Jun 8, 2023
@hfxsd hfxsd requested a review from Frank945946 June 8, 2023 06:47
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2023
@hfxsd hfxsd added type/bugfix This PR fixes a bug. translation/no-need No need to translate this PR. area/dm area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed missing-translation-status This PR does not have translation status info. labels Jun 8, 2023
Frank945946
Frank945946 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@Frank945946 Frank945946 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Frank945946
Frank945946 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@Frank945946 Frank945946 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qiancai
qiancai approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hfxsd
Copy link
Collaborator Author

hfxsd commented Jun 8, 2023

/merge

2 similar comments
@hfxsd
Copy link
Collaborator Author

hfxsd commented Jun 8, 2023

/merge

@hfxsd
Copy link
Collaborator Author

hfxsd commented Jun 8, 2023

/merge

hfxsd
hfxsd commented Jun 8, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 8, 2023
@hfxsd
Copy link
Collaborator Author

hfxsd commented Jun 8, 2023

/verify

@hfxsd
Copy link
Collaborator Author

hfxsd commented Jun 8, 2023

/merge

@hfxsd
Copy link
Collaborator Author

hfxsd commented Jun 8, 2023

/approve

@qiancai qiancai added the lgtm label Jun 8, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 8, 2023
@qiancai
Copy link
Collaborator

qiancai commented Jun 8, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 8, 2023
@qiancai
Copy link
Collaborator

qiancai commented Jun 8, 2023

/lgtm

qiancai
qiancai approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

@qiancai: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pingcap pingcap deleted a comment from ti-chi-bot bot Jun 8, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 8, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 8, 2023
@qiancai qiancai added the lgtm label Jun 8, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 8, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 8, 2023

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Jun 8, 2023

/lgtm cancel

1 similar comment
@qiancai
Copy link
Collaborator

qiancai commented Jun 8, 2023

/lgtm cancel

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 8, 2023

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator

qiancai commented Jun 8, 2023

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

@qiancai: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator

qiancai commented Jun 8, 2023

/lgtm cancel

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 8, 2023
@qiancai
Copy link
Collaborator

qiancai commented Jun 8, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 8, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 8, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-08 07:49:26.737504817 +0000 UTC m=+443.263306732: ☑️ agreed by qiancai.
  • 2023-06-08 08:36:34.613439005 +0000 UTC m=+173.448712047: ✖️🔁 reset by hfxsd.
  • 2023-06-08 09:01:57.755835633 +0000 UTC m=+246.084524103: ☑️ agreed by qiancai.
  • 2023-06-08 09:14:36.377320509 +0000 UTC m=+1004.706008979: ☑️ agreed by Oreoxmt.
  • 2023-06-08 09:32:56.372453564 +0000 UTC m=+2104.701142034: ✖️🔁 reset by qiancai.
  • 2023-06-08 09:34:11.932259417 +0000 UTC m=+2180.260947887: ☑️ agreed by qiancai.
  • 2023-06-08 09:35:38.669871117 +0000 UTC m=+2266.998559587: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator

qiancai commented Jun 8, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd, qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hfxsd
Copy link
Collaborator Author

hfxsd commented Jun 8, 2023

byebye!

@hfxsd hfxsd closed this Jun 8, 2023
@lilin90 lilin90 mentioned this pull request Jun 8, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai approved these changes

+1 more reviewer

@Frank945946 Frank945946 Frank945946 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hfxsd hfxsd

@qiancai qiancai

Labels

approved area/dm area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hfxsd @qiancai @Oreoxmt @Frank945946