Skip to content

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Jun 8, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Deleted the compression format for Parquet because Parquet does not support it.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Jun 8, 2023
@hfxsd hfxsd requested a review from qiancai June 8, 2023 09:58
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Jun 8, 2023
@hfxsd hfxsd requested a review from Oreoxmt June 8, 2023 09:58
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2023
@hfxsd hfxsd added type/bugfix This PR fixes a bug. translation/no-need No need to translate this PR. area/dm area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed missing-translation-status This PR does not have translation status info. labels Jun 8, 2023
@lilin90
Copy link
Member

lilin90 commented Jun 8, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 8, 2023
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-08 10:03:22.779059011 +0000 UTC m=+3931.107747476: ☑️ agreed by lilin90.
  • 2023-06-08 10:09:11.214538014 +0000 UTC m=+4279.543226483: ☑️ agreed by Oreoxmt.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Jun 8, 2023

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 8, 2023
@lilin90
Copy link
Member

lilin90 commented Jun 8, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd, lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot added lgtm and removed lgtm labels Jun 8, 2023
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 8, 2023

/run-verify

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 8, 2023

/verify

@ti-chi-bot ti-chi-bot bot merged commit 2dbe3d9 into pingcap:release-6.5 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/dm area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants