Skip to content

lightning: update docs for duplicate detection#14343

Merged
ti-chi-bot[bot] merged 27 commits intomasterfrom
lance6716-patch-2
Aug 7, 2023
Merged

lightning: update docs for duplicate detection#14343
ti-chi-bot[bot] merged 27 commits intomasterfrom
lance6716-patch-2

Conversation

@lance6716
Copy link
Copy Markdown
Contributor

@lance6716 lance6716 commented Jul 25, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2023
@hfxsd hfxsd self-assigned this Jul 26, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2023
@lance6716 lance6716 changed the title [WIP]lightning: update docs for duplicate detection lightning: update docs for duplicate detection Jul 26, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
@hfxsd hfxsd added v7.3 This PR/issue applies to TiDB v7.3. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. and removed missing-translation-status This PR does not have translation status info. labels Jul 26, 2023
@hfxsd hfxsd requested review from Frank945946 and hfxsd July 26, 2023 05:22
Comment thread tidb-lightning/tidb-lightning-error-resolution.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-error-resolution.md Outdated
Comment thread tidb-lightning/tidb-lightning-error-resolution.md
Comment thread tidb-lightning/tidb-lightning-error-resolution.md Outdated
Comment thread tidb-lightning/tidb-lightning-error-resolution.md Outdated
Comment thread tidb-lightning/tidb-lightning-error-resolution.md Outdated
Comment thread tidb-lightning/tidb-lightning-error-resolution.md Outdated
Comment thread tidb-lightning/tidb-lightning-error-resolution.md Outdated
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
Comment thread tidb-lightning/tidb-lightning-physical-import-mode-usage.md Outdated
Comment thread tidb-lightning/tidb-lightning-error-resolution.md Outdated
Comment thread tidb-lightning/tidb-lightning-physical-import-mode-usage.md Outdated
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt self-requested a review August 7, 2023 02:06
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-error-resolution.md Outdated
Comment thread tidb-lightning/tidb-lightning-physical-import-mode-usage.md Outdated
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2023
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Aug 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-31 13:07:32.410488963 +0000 UTC m=+104336.352837488: ☑️ agreed by hfxsd.
  • 2023-08-07 02:21:27.534446661 +0000 UTC m=+670371.476795197: ☑️ agreed by Oreoxmt.

Comment thread tidb-lightning/tidb-lightning-logical-import-mode-usage.md Outdated
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Aug 7, 2023

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.3 This PR/issue applies to TiDB v7.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants