Skip to content

Small updates to TiKV config docs #17976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 27, 2024
Merged

Small updates to TiKV config docs #17976

merged 6 commits into from
Jun 27, 2024

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Jun 20, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2024
@dveeden dveeden requested review from Oreoxmt and qiancai June 20, 2024 07:03
@dveeden dveeden requested a review from pingyu June 20, 2024 07:31
pingyu
pingyu reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue affect versions since v6.1.

@Oreoxmt Oreoxmt self-assigned this Jun 20, 2024
@Oreoxmt Oreoxmt added the translation/doing This PR's assignee is translating this PR. label Jun 20, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 20, 2024
pingyu
pingyu approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2024

@pingyu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM~

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 20, 2024
@Oreoxmt Oreoxmt removed the request for review from qiancai June 21, 2024 07:28
Oreoxmt
Oreoxmt reviewed Jun 21, 2024
View reviewed changes
dveeden and others added 2 commits June 21, 2024 10:15
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-27 07:28:39.760002732 +0000 UTC m=+877446.245491565: ☑️ agreed by Oreoxmt.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 27, 2024
@Oreoxmt Oreoxmt added the lgtm label Jun 27, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 27, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 27, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 27, 2024

In response to a cherrypick label: new pull request created to branch release-6.1: #18040.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 27, 2024

In response to a cherrypick label: new pull request created to branch release-6.5: #18041.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 27, 2024
@dveeden @ti-chi-bot
This is an automated cherry-pick of pingcap#17976
998de72 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 27, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 27, 2024

In response to a cherrypick label: new pull request created to branch release-7.1: #18042.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 27, 2024
@dveeden @ti-chi-bot
This is an automated cherry-pick of pingcap#17976
40d8128 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 27, 2024
Merged
17 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 27, 2024
@dveeden @ti-chi-bot
This is an automated cherry-pick of pingcap#17976
f369668 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 27, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #18043.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 27, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 27, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #18044.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 27, 2024
Merged
17 tasks
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 27, 2024
@dveeden @Oreoxmt
Small updates to TiKV config docs (pingcap#17976)
f02d692
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 27, 2024
@dveeden @Oreoxmt
Small updates to TiKV config docs (pingcap#17976)
f739f1a
ti-chi-bot bot pushed a commit that referenced this pull request Jun 27, 2024
@ti-chi-bot
Small updates to TiKV config docs (#17976) (#18042)
5639ada
ti-chi-bot bot pushed a commit that referenced this pull request Jun 27, 2024
@ti-chi-bot
Small updates to TiKV config docs (#17976) (#18041)
5150085
ti-chi-bot bot pushed a commit that referenced this pull request Jun 27, 2024
@ti-chi-bot
Small updates to TiKV config docs (#17976) (#18043)
29fb9b5
ti-chi-bot bot pushed a commit that referenced this pull request Jun 27, 2024
@ti-chi-bot
Small updates to TiKV config docs (#17976) (#18040)
b3351b8
ti-chi-bot bot pushed a commit that referenced this pull request Jun 27, 2024
@ti-chi-bot
Small updates to TiKV config docs (#17976) (#18044)
831c96c
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Mar 19, 2025
@Oreoxmt Oreoxmt mentioned this pull request Mar 19, 2025
Merged
17 tasks
This was referenced Mar 19, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pingyu pingyu pingyu approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dveeden @Oreoxmt @ti-chi-bot @pingyu