Skip to content

br: provide a storage target option for BR restore checkpoint data #20492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 5 commits into from
Apr 10, 2025
Merged

br: provide a storage target option for BR restore checkpoint data #20492

ti-chi-bot merged 5 commits into from
Apr 10, 2025

Conversation

@Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Mar 10, 2025 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Leavrth
draft
f7b91c8 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2025
@Leavrth
commit some suggestions
12afa92 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@hfxsd hfxsd self-assigned this Mar 10, 2025
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. and removed missing-translation-status This PR does not have translation status info. labels Mar 10, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 10, 2025

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Mar 10, 2025
hfxsd
hfxsd reviewed Mar 20, 2025
View reviewed changes
hfxsd
hfxsd reviewed Mar 20, 2025
View reviewed changes
hfxsd
hfxsd reviewed Mar 20, 2025
View reviewed changes
hfxsd
hfxsd reviewed Mar 20, 2025
View reviewed changes
hfxsd
hfxsd reviewed Mar 20, 2025
View reviewed changes
@hfxsd hfxsd requested a review from Oreoxmt March 20, 2025 02:30
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 31, 2025
Oreoxmt
Oreoxmt reviewed Apr 9, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 9, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 9, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 9, 2025
View reviewed changes
Oreoxmt
Oreoxmt approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2025
@hfxsd @Oreoxmt
Apply suggestions from code review
03de8d9 
Co-authored-by: Aolin <aolinz@outlook.com>
@gemini-code-assist
Copy link

gemini-code-assist bot commented Apr 10, 2025

Warning

You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again!

2 similar comments
@gemini-code-assist
Copy link

gemini-code-assist bot commented Apr 10, 2025

Warning

You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again!

@gemini-code-assist
Copy link

gemini-code-assist bot commented Apr 10, 2025

Warning

You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again!

@gemini-code-assist
Copy link

gemini-code-assist bot commented Apr 10, 2025

Warning

You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again!

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 10, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-09 07:51:28.975008702 +0000 UTC m=+2242782.659244797: ☑️ agreed by Oreoxmt.
  • 2025-04-10 02:36:07.91629929 +0000 UTC m=+2310261.600535384: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Apr 10, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 10, 2025
@ti-chi-bot ti-chi-bot bot merged commit b6b8773 into pingcap:master Apr 10, 2025
9 checks passed
@lilin90 lilin90 mentioned this pull request Dec 24, 2025
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hfxsd hfxsd hfxsd approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

@hfxsd hfxsd

Labels

approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Leavrth @hfxsd @Oreoxmt @BornChanger