Skip to content

release notes: fix version in links#20835

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
hfxsd:fix-version-in-rn-8.5.1
Apr 23, 2025
Merged

release notes: fix version in links#20835
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
hfxsd:fix-version-in-rn-8.5.1

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Apr 22, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Apr 22, 2025
@hfxsd hfxsd requested a review from qiancai April 22, 2025 14:57
@ti-chi-bot ti-chi-bot Bot added the contribution This PR is from a community contributor. label Apr 22, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue in the release notes for TiDB version 8.5.1. Specifically, it corrects the links for 'Quick start' and 'Production deployment' to point to the v8.5 documentation instead of the v8.1 documentation. The PR also indicates that the changes apply to both the master branch and the v8.5 release branch.

Highlights

  • Bug fix: Corrects the Quick Start and Production Deployment links in the release notes for TiDB v8.5.1 to point to the correct version of the documentation.
  • Version Specific: The changes apply to both the master branch and the v8.5 release branch.

Changelog

  • releases/release-8.5.1.md
    • Updated the 'Quick start' link to point to the v8.5 documentation.
    • Updated the 'Production deployment' link to point to the v8.5 documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses an issue where the version numbers in the quick access links of the release notes were incorrect. The changes are straightforward and correct the links to point to the proper documentation for the 8.5 release. The changes adhere to the style guide.

Merge Readiness

The pull request is ready for merging. The changes are simple and correct the identified issue. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.

@hfxsd hfxsd added translation/no-need No need to translate this PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2025
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 22, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-22 15:33:29.861784026 +0000 UTC m=+369753.673574404: ☑️ agreed by qiancai.

@hfxsd hfxsd added the lgtm label Apr 23, 2025
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Apr 23, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 23, 2025
@ti-chi-bot ti-chi-bot Bot merged commit d85c464 into pingcap:master Apr 23, 2025
9 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20837.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants