serverless support import into (#20832) #20843
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
do-not-merge/hold
|
@zeminzhou This PR has conflicts, I have hold it. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request is an automated cherry-pick of #20832. It updates the documentation for TiDB to reflect the availability of the IMPORT INTO feature in TiDB Cloud Serverless, and to remove notes indicating that certain import-related features are unavailable on TiDB Cloud Serverless. Specifically, it modifies sql-statement-cancel-import-job.md, sql-statement-import-into.md, and sql-statement-show-import-job.md.
Highlights
- Serverless Support: The pull request updates documentation to reflect the availability of
IMPORT INTOin TiDB Cloud Serverless. - Feature Availability: The pull request removes notes indicating that
CANCEL IMPORT,SHOW IMPORT, and Global Sort are unavailable on TiDB Cloud Serverless. - Storage Locations: The pull request clarifies supported storage locations for
IMPORT INTO ... FROM FILEin different TiDB Cloud tiers.
Changelog
- sql-statements/sql-statement-cancel-import-job.md
- Removed the note indicating that
CANCEL IMPORTis not available on TiDB Cloud Serverless.
- Removed the note indicating that
- sql-statements/sql-statement-import-into.md
- Added information about supported storage locations for
IMPORT INTO ... FROM FILEin TiDB Self-Managed, TiDB Cloud Dedicated, and TiDB Cloud Serverless. - Clarified that Amazon S3 and Alibaba Cloud OSS are supported for TiDB Cloud Serverless.
- Added information about the TiDB Distributed eXecution Framework (DXF) and its impact on
IMPORT INTOperformance. - Removed the warning indicating that Global Sort is experimental.
- Added a note indicating that Global Sort is not available on TiDB Cloud Serverless.
- Added information about supported storage locations for
- sql-statements/sql-statement-show-import-job.md
- Removed the note indicating that
SHOW IMPORTis not available on TiDB Cloud Serverless.
- Removed the note indicating that
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
size/M
There was a problem hiding this comment.
Code Review
The pull request aims to add serverless support for the IMPORT INTO statement. The changes involve removing notes indicating the unavailability of certain features on TiDB Cloud Serverless clusters and adding information about supported storage options for different TiDB Cloud tiers. Overall, the changes seem reasonable, but there are some areas that could be improved for clarity and consistency.
Summary of Findings
- Inconsistent Terminology: The phrase
IMPORT INTO ... FROM FILEis used in some places but not others. It would be good to standardize on one or the other. - Merge Conflicts: The diffs contain merge conflict markers (
<<<<<<< HEAD,=======,>>>>>>>) that need to be resolved before merging. - Style Guide Adherence: There are some instances where the writing style could be improved to adhere to the documentation style guide, particularly regarding clarity and simplicity.[^1]
Merge Readiness
The pull request is not ready for merging due to the presence of merge conflict markers. These must be resolved first. Additionally, addressing the other comments regarding clarity and style would improve the overall quality of the documentation. I am unable to approve this pull request, and recommend that another reviewer approves this code before merging.
|
@gemini-code-assist[bot]: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
size/S
qiancai
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
This is an automated cherry-pick of #20832
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?