serverless support import into #20832
Conversation
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
ti-chi-bot
bot
added
the
first-time-contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @zeminzhou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the documentation for IMPORT INTO ... FROM FILE to reflect its availability on TiDB Cloud Serverless clusters, specifically when importing data from Amazon S3 and Alibaba Cloud OSS. It also clarifies that Global Sort is not available on TiDB Cloud Serverless clusters. The changes involve removing a note that previously stated IMPORT INTO ... FROM FILE was unavailable on Serverless clusters and adding a statement specifying the supported cloud storage options for Serverless.
Highlights
- Serverless Support: The documentation is updated to indicate that
IMPORT INTO ... FROM FILEis supported on TiDB Cloud Serverless clusters when using Amazon S3 and Alibaba Cloud OSS. - Global Sort Clarification: The documentation now explicitly states that Global Sort is not available on TiDB Cloud Serverless clusters.
Changelog
- sql-statements/sql-statement-import-into.md
- Removed the note indicating that
IMPORT INTO ... FROM FILEis not available on TiDB Cloud Serverless. - Added Alibaba Cloud OSS as a supported storage option for
IMPORT INTO ... FROM FILEon TiDB Cloud Serverless. - Added a statement clarifying that Global Sort is not available on TiDB Cloud Serverless clusters.
- Removed the note indicating that
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
missing-translation-status
There was a problem hiding this comment.
Code Review
The pull request updates the documentation to reflect the availability of IMPORT INTO ... FROM FILE on TiDB Cloud Serverless clusters and clarifies the unavailability of Global Sort on these clusters. The changes are straightforward and seem correct. I have provided some minor suggestions for clarity and adherence to the style guide.
Merge Readiness
The changes in this pull request seem correct and improve the documentation. After addressing the minor suggestions, the pull request should be ready to be merged. I am unable to directly approve this pull request, and the author should seek additional reviews and approvals from others before merging.
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
ti-chi-bot
bot
added
size/S
qiancai
added
needs-cherry-pick-release-7.5
|
@baiyuqing: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM |
[LGTM Timeline notifier]Timeline:
|
qiancai
added
the
needs-cherry-pick-release-8.5
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?